From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LW2UZ-0002vD-8q
	for qemu-devel@nongnu.org; Sun, 08 Feb 2009 00:46:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LW2UX-0002uN-Mb
	for qemu-devel@nongnu.org; Sun, 08 Feb 2009 00:46:06 -0500
Received: from [199.232.76.173] (port=51402 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LW2UX-0002uH-H9
	for qemu-devel@nongnu.org; Sun, 08 Feb 2009 00:46:05 -0500
Received: from mx2.redhat.com ([66.187.237.31]:54288)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mtosatti@redhat.com>) id 1LW2UW-0006pM-Vf
	for qemu-devel@nongnu.org; Sun, 08 Feb 2009 00:46:05 -0500
Date: Fri, 6 Feb 2009 15:34:08 -0200
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [Qemu-devel] [patch 13/18] qemu: warn if PCI region is not
	power of two
Message-ID: <20090206173408.GA22784@amt.cnet>
References: <20090204133303.113145633@localhost.localdomain>
	<20090204133924.445066836@localhost.localdomain>
	<200902041438.06018.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200902041438.06018.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

On Wed, Feb 04, 2009 at 02:38:05PM +0000, Paul Brook wrote:
> This should be an error. It is a requirement of the PCI spec, and not 
> something that's user configurable. Any odd sizes indicate a fairly serious 
> bug elsewhere in qemu.
> 
> Paul

qemu: bail out if PCI region is not power of two

Otherwise the PCI size for such regions can be calculated erroneously.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

Index: trunk/hw/pci.c
===================================================================
--- trunk.orig/hw/pci.c
+++ trunk/hw/pci.c
@@ -249,6 +249,13 @@ void pci_register_io_region(PCIDevice *p
 
     if ((unsigned int)region_num >= PCI_NUM_REGIONS)
         return;
+
+    if (size & (size-1)) {
+        term_printf("ERROR: PCI region size must be pow2 "
+                    "type=0x%x, size=0x%x\n", type, size);
+        exit(1);
+    }
+
     r = &pci_dev->io_regions[region_num];
     r->addr = -1;
     r->size = size;