From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVp12-0001f9-8W for qemu-devel@nongnu.org; Sat, 07 Feb 2009 10:22:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVp11-0001eY-Ag for qemu-devel@nongnu.org; Sat, 07 Feb 2009 10:22:43 -0500 Received: from [199.232.76.173] (port=48974 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVp11-0001eK-4R for qemu-devel@nongnu.org; Sat, 07 Feb 2009 10:22:43 -0500 Received: from hall.aurel32.net ([88.191.82.174]:43630) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LVp10-0003a3-K3 for qemu-devel@nongnu.org; Sat, 07 Feb 2009 10:22:42 -0500 Date: Sat, 7 Feb 2009 16:20:35 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] Fix cpu_arm_handle_mmu_fault warning Message-ID: <20090207152035.GF6533@volta.aurel32.net> References: <1233021372-15655-2-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1233021372-15655-2-git-send-email-froydnj@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org On Mon, Jan 26, 2009 at 05:56:11PM -0800, Nathan Froyd wrote: > This patch fixes: > > /scratch/froydnj/qemu.git/target-arm/helper.c:451: warning: no previous prototype for 'cpu_arm_handle_mmu_fault' > > by moving the declaration of the function to cpu.h from exec.h. cpu.h > seems to be the place most other ports declare the corresponding > function. > > --- > target-arm/cpu.h | 2 ++ > target-arm/exec.h | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) Thanks, applied. > diff --git a/target-arm/cpu.h b/target-arm/cpu.h > index 54c2c2e..cab80cd 100644 > --- a/target-arm/cpu.h > +++ b/target-arm/cpu.h > @@ -217,6 +217,8 @@ uint32_t do_arm_semihosting(CPUARMState *env); > is returned if the signal was handled by the virtual CPU. */ > int cpu_arm_signal_handler(int host_signum, void *pinfo, > void *puc); > +int cpu_arm_handle_mmu_fault (CPUARMState *env, target_ulong address, int rw, > + int mmu_idx, int is_softmuu); > > void cpu_lock(void); > void cpu_unlock(void); > diff --git a/target-arm/exec.h b/target-arm/exec.h > index b70e0cb..3e4083a 100644 > --- a/target-arm/exec.h > +++ b/target-arm/exec.h > @@ -37,9 +37,6 @@ static inline void regs_to_env(void) > { > } > > -int cpu_arm_handle_mmu_fault (CPUState *env, target_ulong address, int rw, > - int mmu_idx, int is_softmmu); > - > static inline int cpu_halted(CPUState *env) { > if (!env->halted) > return 0; > -- > 1.6.0.5 > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net