Re: [OpenBIOS] [Qemu-devel] [PATCH, RFC] Mac99 (CHRP?) support

[Aurelien Jarno <aurelien@aurel32.net>]

On Sat, Feb 07, 2009 at 11:05:52PM +0200, Blue Swirl wrote:
> On 2/7/09, Blue Swirl <blauwirbel@gmail.com> wrote:
> > On 2/7/09, Aurelien Jarno <aurelien@aurel32.net> wrote:
> >  > On Sat, Feb 07, 2009 at 01:38:58PM +0200, Blue Swirl wrote:
> >  >  > Hi,
> >  >
> >  > Hi!
> >  >
> >  >  > This set of patches adds basic support for Mac99 Qemu machine,
> >  >
> >  >
> >  > As you ask the question in the subject, this machine is a NewWorld
> >  >  machine, and not a CHRP one. I think we don't really want to provide a
> >  >  CHRP emulated machine, so the best is probably to rename ppc_chrp.c into
> >  >  ppc_newworld.c.
> >
> >
> > True. I think RS6000 series were closest to CHRP, not iMac.
> >
> >  The rename does not affect OHW status, so it could be done immediately.
> >
> >
> >  >  > provided by ppc_chrp.c. I've used the device tree of iMac DV ('99) as
> >  >  > reference:
> >  >  > http://penguinppc.org/historical/dev-trees-html/imac-dv-99.html
> >  >  >
> >  >  > The patches changes the machine to use OpenBIOS instead of OHW and
> >  >  > otherwise breaks OHW assumptions. On OpenBIOS side there are still
> >  >  > some missing bits.
> >  >  >
> >  >  > Comments welcome.
> >  >
> >  >
> >  > Great work.
> >  >
> >  >  I gave a quick look at the patches, they looks fine. However I still
> >  >  experience some problem with the PowerMac IDE emulation, especially with
> >  >  recent kernels, so until it is fixed (Laurent is working on that) I
> >  >  think we should keep the CMD646 as a default.
> >
> >
> > OK¸ I'll change that part and send new patches.
> 
> This new set of patches perform the rename (to be replaced with SVN
> operation). CMD646 is used instead of pmac ide.
> 
> Debian 4.0 R6 cd image boots, installer starts but keyboard does not
> work (probably because OpenBIOS doesn't advertise OpenPic).

That may be the problem. Alternatively, note that NewWorld machine are
not suppose to support ADB bus, so maybe the kernel is disabling that
part. We should switch the keyboard and the mouse to USB as on real
machines. We already have the code on the QEMU side, so it should be
easy. On the OpenBIOS side the code to support an USB keyboard is
probably more complicated.

> The 6th patch is not wanted, it just switches CMD646 back to pmac, but
> it's there if someone wants to play.
> 
> Should these be committed or do we want to wait for more OpenBIOS
> updates? At least the OpenBIOS patch, patch #0 and patch #5 are
> harmless.

For QEMU, I think there is no problem with that. For OpenBIOS, I think
as long as the patches don't break the OldWorld platform, they can be
applied.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net