Re: [Qemu-devel] [patch 13/18] qemu: warn if PCI region is not power of two

[Marcelo Tosatti <mtosatti@redhat.com>]

On Sun, Feb 08, 2009 at 09:08:14AM +0300, malc wrote:
> > --- trunk.orig/hw/pci.c
> > +++ trunk/hw/pci.c
> > @@ -249,6 +249,13 @@ void pci_register_io_region(PCIDevice *p
> >  
> >      if ((unsigned int)region_num >= PCI_NUM_REGIONS)
> >          return;
> > +
> > +    if (size & (size-1)) {
> > +        term_printf("ERROR: PCI region size must be pow2 "
> > +                    "type=0x%x, size=0x%x\n", type, size);
> > +        exit(1);
> > +    }
> > +
> 
> If monitor is on a vc the error message would never be seen, perhaps
> it's better to fprintf it stderr instead?

Agreed, will fix. Thanks.