From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWII8-0008Pz-1G for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:38:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWII6-0008P3-Io for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:38:19 -0500 Received: from [199.232.76.173] (port=50680 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWII6-0008P0-DP for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:38:18 -0500 Received: from mx20.gnu.org ([199.232.41.8]:62939) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWII6-0006bh-4h for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:38:18 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWII4-0005bg-EB for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:38:16 -0500 Date: Sun, 8 Feb 2009 14:38:13 -0800 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH 06/14] Add v{max,min}fp instructions Message-ID: <20090208223813.GN15286@codesourcery.com> References: <1232657054-30100-1-git-send-email-froydnj@codesourcery.com> <1232657054-30100-7-git-send-email-froydnj@codesourcery.com> <20090203195113.GB18984@volta.aurel32.net> <20090204090631.GA19995@volta.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090204090631.GA19995@volta.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Use float32_lt_quiet instead of an explicit lt/eq/gt/un compare, since we already handled NaNs earlier. Signed-off-by: Nathan Froyd --- target-ppc/helper.h | 2 ++ target-ppc/op_helper.c | 18 ++++++++++++++++++ target-ppc/translate.c | 2 ++ 3 files changed, 22 insertions(+), 0 deletions(-) diff --git a/target-ppc/helper.h b/target-ppc/helper.h index 1c1e878..1c76586 100644 --- a/target-ppc/helper.h +++ b/target-ppc/helper.h @@ -232,6 +232,8 @@ DEF_HELPER_3(vsum2sws, void, avr, avr, avr) DEF_HELPER_3(vsum4sbs, void, avr, avr, avr) DEF_HELPER_3(vsum4shs, void, avr, avr, avr) DEF_HELPER_3(vsum4ubs, void, avr, avr, avr) +DEF_HELPER_3(vmaxfp, void, avr, avr, avr) +DEF_HELPER_3(vminfp, void, avr, avr, avr) DEF_HELPER_2(vlogefp, void, avr, avr) DEF_HELPER_2(vrfim, void, avr, avr) DEF_HELPER_2(vrfin, void, avr, avr) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c index 715f86b..674a21d 100644 --- a/target-ppc/op_helper.c +++ b/target-ppc/op_helper.c @@ -2262,6 +2262,24 @@ VMINMAX(uw, u32) #undef VMINMAX_DO #undef VMINMAX +#define VMINMAXFP(suffix, rT, rF) \ + void helper_v##suffix (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \ + { \ + int i; \ + for (i = 0; i < ARRAY_SIZE(r->f); i++) { \ + HANDLE_NAN2(r->f[i], a->f[i], b->f[i]) { \ + if (float32_lt_quiet(a->f[i], b->f[i], &env->vec_status)) { \ + r->f[i] = rT->f[i]; \ + } else { \ + r->f[i] = rF->f[i]; \ + } \ + } \ + } \ + } +VMINMAXFP(minfp, a, b) +VMINMAXFP(maxfp, b, a) +#undef VMINMAXFP + void helper_vmladduhm (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c) { int i; diff --git a/target-ppc/translate.c b/target-ppc/translate.c index e829498..1f6386b 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -6395,6 +6395,8 @@ GEN_VXFORM(vsum4sbs, 4, 28); GEN_VXFORM(vsum4shs, 4, 25); GEN_VXFORM(vsum2sws, 4, 26); GEN_VXFORM(vsumsws, 4, 30); +GEN_VXFORM(vmaxfp, 5, 16); +GEN_VXFORM(vminfp, 5, 17); #define GEN_VXRFORM1(opname, name, str, opc2, opc3) \ GEN_HANDLER2(name, str, 0x4, opc2, opc3, 0x00000000, PPC_ALTIVEC) \ -- 1.6.0.5