From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWIJO-0000qj-UI for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:39:38 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWIJO-0000qW-Ip for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:39:38 -0500 Received: from [199.232.76.173] (port=50688 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWIJO-0000qT-Ck for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:39:38 -0500 Received: from mx20.gnu.org ([199.232.41.8]:62947) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWIJO-0006fX-1L for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:39:38 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWIJN-0005dI-BO for qemu-devel@nongnu.org; Sun, 08 Feb 2009 17:39:37 -0500 Date: Sun, 8 Feb 2009 14:39:34 -0800 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH 08/14] Add vmaddfp and vnmsubfp instructions Message-ID: <20090208223934.GP15286@codesourcery.com> References: <1232657054-30100-1-git-send-email-froydnj@codesourcery.com> <1232657054-30100-9-git-send-email-froydnj@codesourcery.com> <20090204103936.GC19995@volta.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090204103936.GC19995@volta.aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Let the softfloat code handle the special cases rather than doing the work ourselves (e.g. magnitude subtraction of infinities). Signed-off-by: Nathan Froyd --- target-ppc/helper.h | 2 ++ target-ppc/op_helper.c | 37 +++++++++++++++++++++++++++++++++++++ target-ppc/translate.c | 1 + 3 files changed, 40 insertions(+), 0 deletions(-) diff --git a/target-ppc/helper.h b/target-ppc/helper.h index 43d1867..af6c839 100644 --- a/target-ppc/helper.h +++ b/target-ppc/helper.h @@ -236,6 +236,8 @@ DEF_HELPER_3(vaddfp, void, avr, avr, avr) DEF_HELPER_3(vsubfp, void, avr, avr, avr) DEF_HELPER_3(vmaxfp, void, avr, avr, avr) DEF_HELPER_3(vminfp, void, avr, avr, avr) +DEF_HELPER_4(vmaddfp, void, avr, avr, avr, avr) +DEF_HELPER_4(vnmsubfp, void, avr, avr, avr, avr) DEF_HELPER_2(vlogefp, void, avr, avr) DEF_HELPER_2(vrfim, void, avr, avr) DEF_HELPER_2(vrfin, void, avr, avr) diff --git a/target-ppc/op_helper.c b/target-ppc/op_helper.c index 6cf47a3..f59cd15 100644 --- a/target-ppc/op_helper.c +++ b/target-ppc/op_helper.c @@ -2220,6 +2220,24 @@ VCMP(gtsw, >, s32) #undef VCMP_DO #undef VCMP +void helper_vmaddfp (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c) +{ + int i; + for (i = 0; i < ARRAY_SIZE(r->f); i++) { + HANDLE_NAN3(r->f[i], a->f[i], b->f[i], c->f[i]) { + /* Need to do the computation in higher precision and round + * once at the end. */ + float64 af, bf, cf, t; + af = float32_to_float64(a->f[i], &env->vec_status); + bf = float32_to_float64(b->f[i], &env->vec_status); + cf = float32_to_float64(c->f[i], &env->vec_status); + t = float64_mul(af, cf, &env->vec_status); + t = float64_add(t, bf, &env->vec_status); + r->f[i] = float64_to_float32(t, &env->vec_status); + } + } +} + void helper_vmhaddshs (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c) { int sat = 0; @@ -2456,6 +2474,25 @@ VMUL(uh, u16, u32) #undef VMUL_DO #undef VMUL +void helper_vnmsubfp (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c) +{ + int i; + for (i = 0; i < ARRAY_SIZE(r->f); i++) { + HANDLE_NAN3(r->f[i], a->f[i], b->f[i], c->f[i]) { + /* Need to do the computation is higher precision and round + * once at the end. */ + float64 af, bf, cf, t; + af = float32_to_float64(a->f[i], &env->vec_status); + bf = float32_to_float64(b->f[i], &env->vec_status); + cf = float32_to_float64(c->f[i], &env->vec_status); + t = float64_mul(af, cf, &env->vec_status); + t = float64_sub(t, bf, &env->vec_status); + t = float64_chs(t); + r->f[i] = float64_to_float32(t, &env->vec_status); + } + } +} + void helper_vperm (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c) { ppc_avr_t result; diff --git a/target-ppc/translate.c b/target-ppc/translate.c index af83b19..88426af 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -6584,6 +6584,7 @@ GEN_VAFORM_PAIRED(vmsumubm, vmsummbm, 18) GEN_VAFORM_PAIRED(vmsumuhm, vmsumuhs, 19) GEN_VAFORM_PAIRED(vmsumshm, vmsumshs, 20) GEN_VAFORM_PAIRED(vsel, vperm, 21) +GEN_VAFORM_PAIRED(vmaddfp, vnmsubfp, 23) /*** SPE extension ***/ /* Register moves */ -- 1.6.0.5