From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWRi4-0005ou-8g for qemu-devel@nongnu.org; Mon, 09 Feb 2009 03:41:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWRi2-0005l4-Pw for qemu-devel@nongnu.org; Mon, 09 Feb 2009 03:41:43 -0500 Received: from [199.232.76.173] (port=50426 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWRi2-0005kf-Ec for qemu-devel@nongnu.org; Mon, 09 Feb 2009 03:41:42 -0500 Received: from mx1.redhat.com ([66.187.233.31]:47127) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWRi2-0002wp-2J for qemu-devel@nongnu.org; Mon, 09 Feb 2009 03:41:42 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n198ffbO013905 for ; Mon, 9 Feb 2009 03:41:41 -0500 Date: Mon, 9 Feb 2009 08:41:39 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [patch 2/2] qemu: PCI device, disk and host network hot-add / hot-remove Message-ID: <20090209084139.GA20629@redhat.com> References: <20090206174406.589893548@amt.cnet> <20090206174840.681967121@amt.cnet> <498EAF22.1030902@redhat.com> <20090208172844.GA3854@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090208172844.GA3854@amt.cnet> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: Markus Armbruster , Avi Kivity , qemu-devel@nongnu.org On Sun, Feb 08, 2009 at 03:28:45PM -0200, Marcelo Tosatti wrote: > On Sun, Feb 08, 2009 at 12:08:34PM +0200, Avi Kivity wrote: > > Marcelo Tosatti wrote: > >> Add monitor command to hot-add PCI devices (nic and storage). > >> Syntax is: > >> pci_add pci_addr=[[:]:] nic|storage params > >> It returns the domain, bus and slot for the newly added device on > >> success > > > > Instead of returning something, how about > > > > pci_add pci_addr=...,name=blah > > > > and then > > > > pci_del blah > > > > 'info pci' could also output the name so that it could be associated > > with the bus address. > > Sure that can be done. Like an alias. So you identify > with a name. I can see it simplifies direct management of hotplug on the > monitor. Also bear in mind that we need the ability to hot unplug devices which were specified on the command line argv. For these we currently have neither the pci , nor are given any 'name'. Markus has previously suggested allowing to be specified on the cli which would let us manually assign & use that info for unplug. A device type specific unique naming would be useful too though. In changeset r6220, Mark McLoughlin provided the ability to give every single NIC a unique name. I'd like to be able to use that name for unplug. For disks, meanwhile we generally know the logic bus,unit,index info as provided to -drive / pci_add disk, which can be used to unplug. So, I'd suggest that pci_del allow either a or some form of unique name, or device type specific unique identifier. Ideally so we can still just as easily use unplug for devices added on the cli, as for those added via the monitor. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|