[Qemu-devel] Header Protection on mac_dbdma.h

[Qemu-devel] Header Protection on mac_dbdma.h

[C.W. Betts]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

I noticed that the header hw/mac_dbdma.h isn't protected from multiple  
inclusions.  The patch fixes that.
Index: hw/mac_dbdma.h
===================================================================
--- hw/mac_dbdma.h	(revision 6564)
+++ hw/mac_dbdma.h	(working copy)
@@ -19,6 +19,8 @@
   * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER  
DEALINGS IN
   * THE SOFTWARE.
   */
+#ifndef __MAC_DBDMA_H__
+#define __MAC_DBDMA_H__

  typedef struct {
      void *opaque;
@@ -39,3 +41,4 @@
                              void *opaque);
  void DBDMA_schedule(void);
  void* DBDMA_init (int *dbdma_mem_index);
+#endif


[-- Attachment #2.1: Type: text/html, Size: 2383 bytes --]

[-- Attachment #2.2: mac_dbdma-patch.diff --]
[-- Type: application/octet-stream, Size: 507 bytes --]

Index: hw/mac_dbdma.h
===================================================================
--- hw/mac_dbdma.h	(revision 6564)
+++ hw/mac_dbdma.h	(working copy)
@@ -19,6 +19,8 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * THE SOFTWARE.
  */
+#ifndef __MAC_DBDMA_H__
+#define __MAC_DBDMA_H__
 
 typedef struct {
     void *opaque;
@@ -39,3 +41,4 @@
                             void *opaque);
 void DBDMA_schedule(void);
 void* DBDMA_init (int *dbdma_mem_index);
+#endif

[-- Attachment #2.3: Type: text/html, Size: 145 bytes --]

Re: [Qemu-devel] Header Protection on mac_dbdma.h

[Aurelien Jarno]

On Sun, Feb 08, 2009 at 10:29:45PM -0700, C.W. Betts wrote:
> I noticed that the header hw/mac_dbdma.h isn't protected from multiple  
> inclusions.  The patch fixes that.

AFAIK, this file is never included twice, so strictly speaking this
patch is not necessary.

Given that about half of the .h files in the hw/ directory do not have 
header protection from multiple inclusions, I would clearly prefer 
fixing all of them, instead of fixing random ones.

> Index: hw/mac_dbdma.h
> ===================================================================
> --- hw/mac_dbdma.h	(revision 6564)
> +++ hw/mac_dbdma.h	(working copy)
> @@ -19,6 +19,8 @@
>   * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER  
> DEALINGS IN
>   * THE SOFTWARE.
>   */
> +#ifndef __MAC_DBDMA_H__
> +#define __MAC_DBDMA_H__
>
>  typedef struct {
>      void *opaque;
> @@ -39,3 +41,4 @@
>                              void *opaque);
>  void DBDMA_schedule(void);
>  void* DBDMA_init (int *dbdma_mem_index);
> +#endif
>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net