From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWZXS-0002Pr-JP for qemu-devel@nongnu.org; Mon, 09 Feb 2009 12:03:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWZXP-0002Np-FJ for qemu-devel@nongnu.org; Mon, 09 Feb 2009 12:03:16 -0500 Received: from [199.232.76.173] (port=33143 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWZXO-0002NT-RS for qemu-devel@nongnu.org; Mon, 09 Feb 2009 12:03:14 -0500 Received: from hall.aurel32.net ([88.191.82.174]:39919) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LWZXO-0005qn-4p for qemu-devel@nongnu.org; Mon, 09 Feb 2009 12:03:14 -0500 Received: from farad.aurel32.net ([82.232.2.251] helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1LWZXM-0007oX-UV for qemu-devel@nongnu.org; Mon, 09 Feb 2009 18:03:13 +0100 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1LWZXM-0008SG-At for qemu-devel@nongnu.org; Mon, 09 Feb 2009 18:03:12 +0100 Date: Mon, 9 Feb 2009 18:03:12 +0100 From: Aurelien Jarno Subject: Re: [Qemu-devel] Header Protection on mac_dbdma.h Message-ID: <20090209170312.GC15149@volta.aurel32.net> References: <8E614A70-215E-4AB5-BDFB-79CEB62914A0@hotmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <8E614A70-215E-4AB5-BDFB-79CEB62914A0@hotmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Feb 08, 2009 at 10:29:45PM -0700, C.W. Betts wrote: > I noticed that the header hw/mac_dbdma.h isn't protected from multiple > inclusions. The patch fixes that. AFAIK, this file is never included twice, so strictly speaking this patch is not necessary. Given that about half of the .h files in the hw/ directory do not have header protection from multiple inclusions, I would clearly prefer fixing all of them, instead of fixing random ones. > Index: hw/mac_dbdma.h > =================================================================== > --- hw/mac_dbdma.h (revision 6564) > +++ hw/mac_dbdma.h (working copy) > @@ -19,6 +19,8 @@ > * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > DEALINGS IN > * THE SOFTWARE. > */ > +#ifndef __MAC_DBDMA_H__ > +#define __MAC_DBDMA_H__ > > typedef struct { > void *opaque; > @@ -39,3 +41,4 @@ > void *opaque); > void DBDMA_schedule(void); > void* DBDMA_init (int *dbdma_mem_index); > +#endif > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net