From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LWcRc-00063j-CB
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 15:09:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LWcRa-000638-4v
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 15:09:27 -0500
Received: from [199.232.76.173] (port=56222 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LWcRZ-00062z-RC
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 15:09:25 -0500
Received: from hall.aurel32.net ([88.191.82.174]:43285)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <aurelien@aurel32.net>)
	id 1LWcRY-0004m6-KH
	for qemu-devel@nongnu.org; Mon, 09 Feb 2009 15:09:25 -0500
Date: Mon, 9 Feb 2009 21:09:19 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [RESEND][PATCH] qemu_chr_open_tcp: allow ipv4 and
	ipv6 options
Message-ID: <20090209200919.GE15149@volta.aurel32.net>
References: <5A5201B4FE9C4DA2863CFFF07051BFB6@FSCPC>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <5A5201B4FE9C4DA2863CFFF07051BFB6@FSCPC>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org

On Mon, Jan 26, 2009 at 09:21:58PM +0100, Sebastian Herbszt wrote:
> Those new options are parsed in qemu-sockets.c. Allow them instead of printing "Unknown option".
>
> - Sebastian

Thanks, applied.

> --- qemu-r6133/qemu-char.c.orig Sat Dec 27 15:55:48 2008
> +++ qemu-r6133/qemu-char.c Sat Dec 27 16:54:23 2008
> @@ -2035,6 +2035,10 @@
>             do_nodelay = 1;
>         } else if (!strncmp(ptr,"to=",3)) {
>             /* nothing, inet_listen() parses this one */;
> +        } else if (!strncmp(ptr,"ipv4",4)) {
> +            /* nothing, inet_connect() and inet_listen() parse this one */;
> +        } else if (!strncmp(ptr,"ipv6",4)) {
> +            /* nothing, inet_connect() and inet_listen() parse this one */;
>         } else {
>             printf("Unknown option: %s\n", ptr);
>             goto fail;
>
>
>
>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net