qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [patch 2/2] qemu: PCI device, disk and host network hot-add / hot-remove
Date: Tue, 10 Feb 2009 12:32:29 +0000	[thread overview]
Message-ID: <200902101232.30279.paul@codesourcery.com> (raw)
In-Reply-To: <20090210122037.GG31871@redhat.com>

> Then info pci shows this:
>
>   ...snip...
>   Bus  0, device   3, function 0:
>     Ethernet controller: PCI device 10ec:8029
>       IRQ 11.
>       BAR0: I/O at 0xc100 [0xc1ff].

Sounds like the real problem is that info pci and info net don't contain 
enough information.

> Yes, if the device already had a unqiue identifier, it some ways it
> would be easier to just be able todo  'nic_del 01:02:03:04:05:02'
> Or for a SCSI disk 'drive_del bus=scsi,index=3'. QEMU ought to have
> enough info internally to be able to map this to the PCI address it
> needs to remove.

It may be reasonably to assume a 1:1 mapping between network interfaces and 
devices (for current devices at least). However the same is not true for 
disks. Adding/removing host adapters, and adding/removing disks should be 
separate operaions. The same strategy could also be used for network devices 
(you create a PCI NIC, then you connect that NIC to a vlan). We're probably 
going to want this separation anyway for machine config files.

Paul

  reply	other threads:[~2009-02-10 12:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-06 17:44 [Qemu-devel] [patch 0/2] pci hotplug v2 Marcelo Tosatti
2009-02-06 17:44 ` [Qemu-devel] [patch 1/2] pci device registration helpers Marcelo Tosatti
2009-02-06 17:44 ` [Qemu-devel] [patch 2/2] qemu: PCI device, disk and host network hot-add / hot-remove Marcelo Tosatti
2009-02-08 10:08   ` Avi Kivity
2009-02-08 17:28     ` Marcelo Tosatti
2009-02-09  8:24       ` Markus Armbruster
2009-02-09  8:41       ` Daniel P. Berrange
2009-02-09 22:41         ` Marcelo Tosatti
2009-02-10 12:20           ` Daniel P. Berrange
2009-02-10 12:32             ` Paul Brook [this message]
2009-02-06 18:35 ` [Qemu-devel] [patch 0/2] pci hotplug v2 Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2009-02-06 18:48 [Qemu-devel] [patch 0/2] pci hotplug v2 (for real) Marcelo Tosatti
2009-02-06 18:48 ` [Qemu-devel] [patch 2/2] qemu: PCI device, disk and host network hot-add / hot-remove Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902101232.30279.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=berrange@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).