From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LX0jv-0006Gp-3S for qemu-devel@nongnu.org; Tue, 10 Feb 2009 17:05:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LX0jr-0006Em-Ky for qemu-devel@nongnu.org; Tue, 10 Feb 2009 17:05:58 -0500 Received: from [199.232.76.173] (port=39928 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LX0jr-0006EF-Di for qemu-devel@nongnu.org; Tue, 10 Feb 2009 17:05:55 -0500 Received: from mail2.shareable.org ([80.68.89.115]:50735) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LX0jq-0000RE-Kt for qemu-devel@nongnu.org; Tue, 10 Feb 2009 17:05:54 -0500 Received: from jamie by mail2.shareable.org with local (Exim 4.63) (envelope-from ) id 1LX0jl-0004Bc-PP for qemu-devel@nongnu.org; Tue, 10 Feb 2009 22:05:49 +0000 Date: Tue, 10 Feb 2009 22:05:49 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [Patch] Add -net dump option Message-ID: <20090210220549.GA15599@shareable.org> References: <20090204102251.GA16599@ulanbator.act-europe.fr> <498C8722.1050306@us.ibm.com> <20090210121504.GA5449@shareable.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Tristan Gingold wrote: > > On Feb 10, 2009, at 1:15 PM, Jamie Lokier wrote: > > >Tristan Gingold wrote: > >>I have fixed this by making slirp client somewhat special: it is > >>always the last client. I think this is > >>the simplest and most efficient method. > > > >Does this change mean "-net user -net user" no longer crashes after > >overflowing the stack? :-) > > This patch makes "-net user -net user" not possible because you can't > have two last clients. > Slightly better ;-) Much better. :-) I spent a few hours once wondering why QEMU worked great until the Windows guest did its first network access, and then QEMU crashed... Turns out I was passing "-net user" twice on the command line, due to a typo in my management program. I'd already had to find workarounds for other crashes in the guest and a bug in QEMU up to that point, so I wasn't expecting it to be so simple :-) -- Jamie