From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LXdf4-0004la-1n
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 10:39:34 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LXdf2-0004iF-8u
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 10:39:33 -0500
Received: from [199.232.76.173] (port=44496 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LXdf2-0004i3-3j
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 10:39:32 -0500
Received: from mx20.gnu.org ([199.232.41.8]:12170)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LXdf1-00036i-Rj
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 10:39:31 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LXdf0-0003Kc-CV
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 10:39:30 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [6609] Parse full PCI device addresses (Markus
	Armbruster)
Date: Thu, 12 Feb 2009 15:39:26 +0000
References: <E1LXGuL-0004v2-7h@cvs.savannah.gnu.org>
In-Reply-To: <E1LXGuL-0004v2-7h@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200902121539.26892.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> This code parses full PCI device addresses.  It then rejects domains
> other than zero, because these are not supported in QEMU.
>...
> + * Parse [[<domain>:]<bus>:]<slot>, return -1 on error
> + */
> +static int pci_parse_devaddr(const char *addr, int *domp, int *busp,
> unsigned *slotp) +{

If we're rejecting nonzero domains then having the parse routine return a 
domain value seems wrong. It's just going to make it harder to verify correct 
operation when domains are implemented.

Paul