From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LXeP4-0003lD-TJ for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:27:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LXeP1-0003jO-ER for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:27:06 -0500 Received: from [199.232.76.173] (port=50917 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LXeP1-0003jA-2s for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:27:03 -0500 Received: from mx20.gnu.org ([199.232.41.8]:13112) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LXeP0-0001BC-3I for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:27:02 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LXeOz-0004m2-1Z for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:27:01 -0500 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH 3/4] qemu:virtio-net: Add support for qemu_vlan_rxfilter Date: Thu, 12 Feb 2009 16:26:58 +0000 References: <20090210212841.9760.96780.stgit@kvm.aw> <20090210212857.9760.31288.stgit@kvm.aw> In-Reply-To: <20090210212857.9760.31288.stgit@kvm.aw> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902121626.58977.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm@vger.kernel.org, Alex Williamson > +static void virtio_net_vlan_client_added(void *opaque) >... > +static void virtio_net_vlan_client_removed(void *opaque) Why are these two different? It looks like what you really want is a callback for "Something changed, and you need to reset your MAC filter." Paul