From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LXebX-0004vi-Je
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:39:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LXebV-0004vL-Bg
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:39:58 -0500
Received: from [199.232.76.173] (port=42948 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LXebV-0004vI-91
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:39:57 -0500
Received: from mx2.redhat.com ([66.187.237.31]:47037)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1LXebS-0003WJ-P3
	for qemu-devel@nongnu.org; Thu, 12 Feb 2009 11:39:57 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1CGdnP2025019
	for <qemu-devel@nongnu.org>; Thu, 12 Feb 2009 11:39:49 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1CGdnrV026011
	for <qemu-devel@nongnu.org>; Thu, 12 Feb 2009 11:39:50 -0500
Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com
	[10.35.1.237])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1CGdmUE004298
	for <qemu-devel@nongnu.org>; Thu, 12 Feb 2009 11:39:49 -0500
Date: Thu, 12 Feb 2009 18:37:10 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Allow additions of ACPI tables from
	command line
Message-ID: <20090212163710.GD13234@redhat.com>
References: <20090212081025.29410.94176.stgit@dhcp-1-237.tlv.redhat.com>
	<f43fc5580902120753n1455e531gc510588428fe65dc@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5580902120753n1455e531gc510588428fe65dc@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Feb 12, 2009 at 05:53:24PM +0200, Blue Swirl wrote:
> On 2/12/09, Gleb Natapov <gleb@redhat.com> wrote:
> > This is needed to dynamically add SLIC tables with Windows
> >  activation keys.
> 
> >  +--- a/bios/rombios32.c
> >  ++++ b/bios/rombios32.c
> >  +@@ -455,6 +455,8 @@ unsigned long bios_table_end_addr;
> >  + #define QEMU_CFG_SIGNATURE  0x00
> >  + #define QEMU_CFG_ID         0x01
> >  + #define QEMU_CFG_UUID       0x02
> >  ++#define FW_CFG_ARCH_LOCAL     0x8000
> >  ++#define FW_CFG_ACPI_TABLES  (FW_CFG_ARCH_LOCAL + 0)
> 
> Why don't you just copy the file hw/fw_cfg.h as is? It's designed to
> be included even from assembler files.
> 
Bochs is another project. We can copy the file once but than we will have to
sync it each time it changes in qemu anyway.

--
			Gleb.