From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LYfP3-0008Qk-Ik for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:43:17 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LYfP1-0008QU-4T for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:43:16 -0500 Received: from [199.232.76.173] (port=51307 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LYfP0-0008QR-Sq for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:43:14 -0500 Received: from mx1.redhat.com ([66.187.233.31]:41202) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LYfP0-00033j-Gd for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:43:14 -0500 Date: Sun, 15 Feb 2009 11:43:12 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] PATCH: 1/7: Extend 'info vnc' output to show client Message-ID: <20090215114312.GF4795@redhat.com> References: <20090212145302.GO9894@redhat.com> <20090212150134.GQ9894@redhat.com> <4995BC63.8040501@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4995BC63.8040501@us.ibm.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Fri, Feb 13, 2009 at 12:30:59PM -0600, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >The current 'info vnc' monitor output just displays the VNC server address > >as provided by the -vnc command line flag. This isn't particularly useful > >since it doesn't tell you what VNC is actually listening on. eg, if you > >use '-vnc :1' it is useful to know whether this translated to > >'0.0.0.0:5901' > >or chose IPv6 ':::5901'. It is also useful to know the address of the > >client that is currently connected. It is also useful to know the active > >authentication (if any). > > > >@@ -2518,3 +2626,11 @@ int vnc_display_open(DisplayState *ds, c > > > > return qemu_set_fd_handler2(vs->lsock, vnc_listen_poll, > > vnc_listen_read, NULL, vs); > > } > >+ > >+/* > >+ * Local variables: > >+ * c-indent-level: 4 > >+ * c-basic-offset: 4 > >+ * tab-width: 8 > >+ * End: > >+ */ > > > > I'd prefer you not add this randomly in a patch. Sorry, I added this to all the files I touched as QEMU's indentation rules don't match the default emacs & emacs will thus mess up all the whitespace. That said vnc.c already has alot of inconsistent whitespace :-( I'll strip this chunk out of future patches before submission. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|