From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LYfPm-0000Fo-49 for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:44:02 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LYfPk-0000Ec-8V for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:44:01 -0500 Received: from [199.232.76.173] (port=51319 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LYfPk-0000ET-0s for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:44:00 -0500 Received: from mx1.redhat.com ([66.187.233.31]:41226) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LYfPj-0003AR-M4 for qemu-devel@nongnu.org; Sun, 15 Feb 2009 06:43:59 -0500 Date: Sun, 15 Feb 2009 11:43:57 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] PATCH: 2/7: Push VncState struct into vnc.h Message-ID: <20090215114357.GG4795@redhat.com> References: <20090212145302.GO9894@redhat.com> <20090212150205.GR9894@redhat.com> <4997411B.9030805@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4997411B.9030805@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Sat, Feb 14, 2009 at 04:09:31PM -0600, Anthony Liguori wrote: > Daniel P. Berrange wrote: > >This patch moves the declaration for the VncState struct out of the > >vnc.c file and into vnc.h. This is to prepare for next patches which > >have the auth mechanisms implementated in separate vnc-auth-vencrypt.c > >and vnc-auth-sasl.c files > > > >In doing this, I discovered that there is a pile of duplicated keymap > >code statically compiled into all the console frontends. A couple of > >trivial changes allowed this to be sanitized, so instead of doing > >a #include "keymaps.c", duplicating all code, we can have a shared > >keymaps.h file, and only compile code once. > > > > It would be better if you split the keymap cleanup into a different patch. Ok, easy enough todo. I'll post new patch to deal with this keymap change first. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|