From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LYj8I-0005j0-Sm for qemu-devel@nongnu.org; Sun, 15 Feb 2009 10:42:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LYj8H-0005ig-BL for qemu-devel@nongnu.org; Sun, 15 Feb 2009 10:42:14 -0500 Received: from [199.232.76.173] (port=37654 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LYj8H-0005id-4m for qemu-devel@nongnu.org; Sun, 15 Feb 2009 10:42:13 -0500 Received: from mail2.shareable.org ([80.68.89.115]:35559) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LYj8G-00089N-Pp for qemu-devel@nongnu.org; Sun, 15 Feb 2009 10:42:12 -0500 Received: from jamie by mail2.shareable.org with local (Exim 4.63) (envelope-from ) id 1LYj8C-0006W7-04 for qemu-devel@nongnu.org; Sun, 15 Feb 2009 15:42:08 +0000 Date: Sun, 15 Feb 2009 15:42:07 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] Revert block-qcow2.c to kvm-72 version due to corruption reports Message-ID: <20090215154207.GA24821@shareable.org> References: <4988AD96.6090308@codemonkey.ws> <20090213084023.GA1020@kos.to> <20090213163043.GJ18471@shareable.org> <4995A723.9010208@codemonkey.ws> <20090213190419.GB20328@shareable.org> <4997502D.1080401@codemonkey.ws> <20090215020126.GA9281@shareable.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > On Sat, Feb 14, 2009 at 8:01 PM, Jamie Lokier wrote: > > Have done, did you read the other thread? > > Yes, but your patch confused me (which is admittedly not hard). > > >> It's QEMU SVN delta 5005-5006, copied below. > > So why such an aggressive revert? Why not just revert the problematic > changesets? Because most of the following changes look too dependent on it. I did keep a couple of changes which are trivially independent since that one - default to "cache=writeback" and eliminating #define offsetof. You have a point that QEMU SVN deltas up to 5005 don't need to be reverted. Reason for that: I simply don't have time to trim the patch down to its bare essentials quickly, and being a corruption bug, it should be dealt with quickly. This one seems to work; feel free to improve it by reverting less, or waiting a long time for me to do so :-) -- Jamie