From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LaOWu-0008Bo-TX
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 01:06:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LaOWt-0008B8-Rb
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 01:06:32 -0500
Received: from [199.232.76.173] (port=49118 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LaOWt-0008Az-87
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 01:06:31 -0500
Received: from 30.mail-out.ovh.net ([213.186.62.213]:40802)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <plagnioj@jcrosoft.com>) id 1LaOWs-0000Bi-MG
	for qemu-devel@nongnu.org; Fri, 20 Feb 2009 01:06:30 -0500
Date: Fri, 20 Feb 2009 06:59:24 +0100
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Subject: Re: [Qemu-devel] SH: Improve the interrupt controller
Message-ID: <20090220055924.GE9141@game.jcrosoft.org>
References: <200812112252.17620.vladimir@codesourcery.com>
	<200902200816.46866.vladimir@codesourcery.com>
	<20090220053249.GD9141@game.jcrosoft.org>
	<200902200858.57065.vladimir@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200902200858.57065.vladimir@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: takasi-y@ops.dti.ne.jp, qemu-devel@nongnu.org

On 08:58 Fri 20 Feb     , Vladimir Prus wrote:
> On Friday 20 February 2009 08:32:49 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 08:16 Fri 20 Feb     , Vladimir Prus wrote:
> > > On Friday 20 February 2009 06:06:57 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > On 14:05 Thu 12 Feb     , Vladimir Prus wrote:
> > > > > On Sunday 08 February 2009 21:57:25 takasi-y@ops.dti.ne.jp wrote:
> > > > > > Hi, Vladimir.
> > > > > > 
> > > > > > I managed to make the code working.
> > > > > > r2d boot, SCI and CF working, and /proc/interrupts increases.
> > > > > > 
> > > > > > Essential points modified are below.
> > > > > > 1. sh_intc_init() caller/callee mismatch.
> > > > > > 2. nobody calls sh_intc_set_irl_priorities()
> > > > > > 3. INTC_MODE_DUAL_SET/CLR swapped
> > > > > > I'm not sure 3 in your patch is on purpose or not.
> > > > > > 
> > > > > > Attached patch is a diff against rev#6563.
> > > > > > This is yours + my small fixes, which are..
> > > > > > - Above three
> > > > > > - sh_intc_set_irl_priorities() has switched to sh_intc_init_irl_priorities().
> > > > > > - sh_intc_set_irl()'s enable hack removed.
> > > > > > - indent,tab/space,brace changed (to what looks like code around)
> > > > > > - reduce INTC_A7() usage
> > > > > > - some others.
> > > > > 
> > > > > Hi Yoshii,
> > > > > I have replaced my original patch with your patch in my patch set, and adjusted
> > > > > sh7785 emulation for your changes. It works, but only after I re-do the
> > > > where can we found this famous sh7785 patch set?
> > > 
> > > Only in my git tree, at the moment. There's one patch there that needs some
> > > rework before it's posted.
> > a link maybe?
> 
> Sorry, I should have said "my local git tree". I can send the entire patch set
> to you, if you're interested.
I'm and I think the other SH4 dev too (as Kawasaki-san)

Best Regards,
J.