From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lb114-0005TR-Re
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:12:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lb112-0005TD-Sj
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:12:14 -0500
Received: from [199.232.76.173] (port=53648 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lb112-0005T8-Od
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:12:12 -0500
Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:29969)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1Lb112-0007Th-8h
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:12:12 -0500
Received: from aamtaout02-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout02-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20090221231210.YWD4080.mtaout02-winn.ispmail.ntl.com@aamtaout02-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Sat, 21 Feb 2009 23:12:10 +0000
Received: from miranda.arrow ([213.107.21.171])
	by aamtaout02-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20090221231210.XPGR21638.aamtaout02-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Sat, 21 Feb 2009 23:12:10 +0000
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1Lb10y-000575-PF
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 23:12:08 +0000
Date: Sat, 21 Feb 2009 23:12:08 +0000
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings
Message-ID: <20090221231208.GA19646@miranda.arrow>
References: <20090221190054.12485.30486.stgit@mchn012c.ww002.siemens.net>
	<20090221190055.12485.92159.stgit@mchn012c.ww002.siemens.net>
	<20090221230359.GA19611@miranda.arrow>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090221230359.GA19611@miranda.arrow>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sat, Feb 21, 2009 at 11:03:59PM +0000, Stuart Brady wrote:
> On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
> > diff --git a/target-cris/translate.c b/target-cris/translate.c
> > index f575e63..954b038 100644
> > --- a/target-cris/translate.c
> > +++ b/target-cris/translate.c
> > @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
> >  static unsigned int dec_movem_mr(DisasContext *dc)
> >  {
> >  	TCGv_i64 tmp[16];
> > -        TCGv tmp32;
> > +        TCGv tmp32 = 0;
> >  	TCGv addr;
> >  	int i;
> >  	int nr = dc->op2 + 1;
> 
> Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.

Also, with 'tmp32 = 0', the build breaks with DEBUG_TCGV defined...

> At the very least, shouldn't there be a comment?  Something like Linux's
> uninitialized_var() macro might be worth considering...
-- 
Stuart Brady