From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings
Date: Sat, 21 Feb 2009 23:14:25 +0000 [thread overview]
Message-ID: <200902212314.26514.paul@codesourcery.com> (raw)
In-Reply-To: <20090221230359.GA19611@miranda.arrow>
On Saturday 21 February 2009, Stuart Brady wrote:
> On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
> > diff --git a/target-cris/translate.c b/target-cris/translate.c
> > index f575e63..954b038 100644
> > --- a/target-cris/translate.c
> > +++ b/target-cris/translate.c
> > @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
> > static unsigned int dec_movem_mr(DisasContext *dc)
> > {
> > TCGv_i64 tmp[16];
> > - TCGv tmp32;
> > + TCGv tmp32 = 0;
> > TCGv addr;
> > int i;
> > int nr = dc->op2 + 1;
>
> Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.
Worse than that, 0 is actively wrong. You obviously haven't built with
DEBUG_TCGV.
> At the very least, shouldn't there be a comment? Something like Linux's
> uninitialized_var() macro might be worth considering...
There already is. TCGV_UNUSED.
Paul
next prev parent reply other threads:[~2009-02-21 23:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 19:00 [Qemu-devel] [PATCH 0/7] clean build - eliminate warnings Jan Kiszka
2009-02-21 19:00 ` [Qemu-devel] [PATCH 3/7] arm: Fix gic_irq_state.level bitfield type Jan Kiszka
2009-03-07 21:48 ` Aurelien Jarno
2009-02-21 19:00 ` [Qemu-devel] [PATCH 2/7] clean build: Fix irq_info and pic_info related warnings Jan Kiszka
2009-02-21 19:00 ` [Qemu-devel] [PATCH 1/7] clean build: Add bt_host_hci prototype Jan Kiszka
2009-03-08 14:56 ` [Qemu-devel] " Jan Kiszka
2009-03-08 18:44 ` Aurelien Jarno
2009-03-08 19:56 ` [Qemu-devel] [PATCH] clean build: Add bt-host.h Jan Kiszka
2009-03-10 21:43 ` Aurelien Jarno
2009-03-10 23:03 ` andrzej zaborowski
2009-03-11 9:02 ` [Qemu-devel] " Jan Kiszka
2009-03-20 14:51 ` andrzej zaborowski
2009-02-21 19:00 ` [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings Jan Kiszka
2009-02-21 23:03 ` Stuart Brady
2009-02-21 23:12 ` Stuart Brady
2009-02-21 23:13 ` Laurent Desnogues
2009-02-22 10:36 ` [Qemu-devel] [PATCH v2 " Jan Kiszka
2009-02-22 14:14 ` Edgar E. Iglesias
2009-02-21 23:14 ` Paul Brook [this message]
2009-02-21 19:00 ` [Qemu-devel] [PATCH 4/7] clean build: Fix arm build warnings Jan Kiszka
2009-03-07 21:48 ` Aurelien Jarno
2009-02-21 19:00 ` [Qemu-devel] [PATCH 6/7] clean build: Fix remaining m68k warnings Jan Kiszka
2009-03-07 21:48 ` Aurelien Jarno
2009-02-21 19:00 ` [Qemu-devel] [PATCH 7/7] clean build: Fix remaining sh4 warnings Jan Kiszka
2009-02-21 19:43 ` [Qemu-devel] [PATCH 0/7] clean build - eliminate warnings Laurent Desnogues
2009-02-21 20:09 ` [Qemu-devel] " Jan Kiszka
2009-02-21 23:08 ` Laurent Desnogues
2009-02-22 10:39 ` Jan Kiszka
2009-02-22 11:09 ` Jan Kiszka
2009-02-22 0:59 ` Edgar E. Iglesias
2009-02-22 10:20 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902212314.26514.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).