From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lb13O-00077Z-VL
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:14:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lb13L-00074J-1U
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:14:38 -0500
Received: from [199.232.76.173] (port=39149 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lb13K-00074F-UW
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:14:34 -0500
Received: from mx20.gnu.org ([199.232.41.8]:20036)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Lb13K-0007jj-MG
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:14:34 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Lb13G-0004oL-Ti
	for qemu-devel@nongnu.org; Sat, 21 Feb 2009 18:14:31 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] clean build: Fix remaining cris warnings
Date: Sat, 21 Feb 2009 23:14:25 +0000
References: <20090221190054.12485.30486.stgit@mchn012c.ww002.siemens.net>
	<20090221190055.12485.92159.stgit@mchn012c.ww002.siemens.net>
	<20090221230359.GA19611@miranda.arrow>
In-Reply-To: <20090221230359.GA19611@miranda.arrow>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200902212314.26514.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>

On Saturday 21 February 2009, Stuart Brady wrote:
> On Sat, Feb 21, 2009 at 08:00:55PM +0100, Jan Kiszka wrote:
> > diff --git a/target-cris/translate.c b/target-cris/translate.c
> > index f575e63..954b038 100644
> > --- a/target-cris/translate.c
> > +++ b/target-cris/translate.c
> > @@ -2613,7 +2613,7 @@ static unsigned int dec_move_pm(DisasContext *dc)
> >  static unsigned int dec_movem_mr(DisasContext *dc)
> >  {
> >  	TCGv_i64 tmp[16];
> > -        TCGv tmp32;
> > +        TCGv tmp32 = 0;
> >  	TCGv addr;
> >  	int i;
> >  	int nr = dc->op2 + 1;
>
> Hmm, GCC just gets it wrong here -- and 0 isn't really very meaningful.

Worse than that, 0 is actively wrong. You obviously haven't built with 
DEBUG_TCGV.

> At the very least, shouldn't there be a comment?  Something like Linux's
> uninitialized_var() macro might be worth considering...

There already is. TCGV_UNUSED.

Paul