From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LcNEL-0004dF-3O
	for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:07:33 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LcNEJ-0004aL-89
	for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:07:32 -0500
Received: from [199.232.76.173] (port=43059 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LcNEI-0004Zr-V3
	for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:07:31 -0500
Received: from mx2.redhat.com ([66.187.237.31]:50065)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <gleb@redhat.com>) id 1LcNEI-00056D-DX
	for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:07:30 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n1PH7SOt027543
	for <qemu-devel@nongnu.org>; Wed, 25 Feb 2009 12:07:28 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n1PH7TRr007318
	for <qemu-devel@nongnu.org>; Wed, 25 Feb 2009 12:07:29 -0500
Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com
	[10.35.1.237])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n1PH7RF3020240
	for <qemu-devel@nongnu.org>; Wed, 25 Feb 2009 12:07:28 -0500
Date: Wed, 25 Feb 2009 19:04:22 +0200
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [6388] Stop VM on ENOSPC error.
Message-ID: <20090225170422.GD8810@redhat.com>
References: <E1LPiI5-0004LB-5o@cvs.savannah.gnu.org>
	<49A577FD.60701@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49A577FD.60701@codemonkey.ws>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Feb 25, 2009 at 10:55:25AM -0600, Anthony Liguori wrote:
> Anthony Liguori wrote:
>> Revision: 6388
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6388
>> Author:   aliguori
>> Date:     2009-01-21 18:59:04 +0000 (Wed, 21 Jan 2009)
>>
>> Log Message:
>> -----------
>> Stop VM on ENOSPC error. (Gleb Natapov)
>>
>> This version of the patch adds new option "werror" to -drive flag.
>> Possible values are:
>>
>> report    - report errors to a guest as IO errors
>> ignore    - continue as if nothing happened
>> stop      - stop VM on any error and retry last command on resume
>> enospc    - stop vm on ENOSPC error and retry last command on resume
>>             all other errors are reported to a guest.
>>
>> Default is "report" to maintain current behaviour.
>>   
>
> I recently got burnt by the default being "report".  I was doing an  
> installation and ran out of disk space.  The guest did not do anything  
> intelligible with the error reports and froze very hard (as you'd 
> expect).
>
> Any objection to changing to default to enospc?
>
Or even to stop. What guest can do with other errors anyway?

--
			Gleb.