From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LcNRJ-0007R3-6o for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:20:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LcNRH-0007Q7-Pv for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:20:56 -0500 Received: from [199.232.76.173] (port=35187 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcNRH-0007Q1-Ft for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:20:55 -0500 Received: from mx20.gnu.org ([199.232.41.8]:49176) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LcNRH-000276-2V for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:20:55 -0500 Received: from mx1.redhat.com ([66.187.233.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LcNRG-0003Kz-0n for qemu-devel@nongnu.org; Wed, 25 Feb 2009 12:20:54 -0500 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n1PHKrPA014522 for ; Wed, 25 Feb 2009 12:20:53 -0500 Date: Wed, 25 Feb 2009 17:20:51 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] [6388] Stop VM on ENOSPC error. Message-ID: <20090225172051.GT24969@redhat.com> References: <49A577FD.60701@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49A577FD.60701@codemonkey.ws> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gleb Natapov On Wed, Feb 25, 2009 at 10:55:25AM -0600, Anthony Liguori wrote: > Anthony Liguori wrote: > >Revision: 6388 > > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6388 > >Author: aliguori > >Date: 2009-01-21 18:59:04 +0000 (Wed, 21 Jan 2009) > > > >Log Message: > >----------- > >Stop VM on ENOSPC error. (Gleb Natapov) > > > >This version of the patch adds new option "werror" to -drive flag. > >Possible values are: > > > >report - report errors to a guest as IO errors > >ignore - continue as if nothing happened > >stop - stop VM on any error and retry last command on resume > >enospc - stop vm on ENOSPC error and retry last command on resume > > all other errors are reported to a guest. > > > >Default is "report" to maintain current behaviour. > > > > I recently got burnt by the default being "report". I was doing an > installation and ran out of disk space. The guest did not do anything > intelligible with the error reports and froze very hard (as you'd expect). > > Any objection to changing to default to enospc? >>From a managment POV having QEMU change its state from running to paused behind our back is hard. You don't want to have to poll on 'info state' to see if the VM has paused, and QEMU provides us no async notification for this yet. So at this time, if QEMU auto-pauses we can't notice this change, and so again it'll just appear to the user as if it froze. If we get async notifications available via the monitor, then making the default enospc is very sensible. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|