From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LclY1-0007AG-4P for qemu-devel@nongnu.org; Thu, 26 Feb 2009 14:05:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LclXz-00078I-5u for qemu-devel@nongnu.org; Thu, 26 Feb 2009 14:05:28 -0500 Received: from [199.232.76.173] (port=39702 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LclXz-00078F-2a for qemu-devel@nongnu.org; Thu, 26 Feb 2009 14:05:27 -0500 Received: from mx2.redhat.com ([66.187.237.31]:56077) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LclXy-0004yL-EE for qemu-devel@nongnu.org; Thu, 26 Feb 2009 14:05:26 -0500 Date: Thu, 26 Feb 2009 17:37:42 +0100 From: Andrea Arcangeli Message-ID: <20090226163741.GT22410@random.random> References: <20090218172920.GH15606@random.random> <49A6BD7D.6040505@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49A6BD7D.6040505@us.ibm.com> Subject: [Qemu-devel] Re: [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #3) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Thu, Feb 26, 2009 at 10:04:13AM -0600, Anthony Liguori wrote: > Andrea Arcangeli wrote: >> + if (bm->aiocb) { >> + QEMU_WARN("qemu_aio_flush called"); >> > > This doesn't build (there is no QEMU_WARN). I think I've mentioned this > before? First patch that triggered some replies didn't have this problem. Must have been a mistake when resending #2 that didn't generate replies. This one below should build too. ------ Subject: avoid cancelling ide dma From: Andrea Arcangeli The reason for not actually canceling the I/O is because with virtualization and lots of VM running, a guest fs may mistake a overload of the host, as an IDE timeout. So rather than canceling the I/O, it's safer to wait I/O completion and simulate that the I/O has completed just before the io cancellation was requested by the guest. This way if ntfs or an app writes data without checking for -EIO retval, and it thinks the write has succeeded, it's less likely to run into troubles. Similar issues for reads. Furthermore because the DMA operation is splitted into many synchronous aio_read/write if there's more than one entry in the SG table, without this patch the DMA would be cancelled in the middle, something we've no idea if it happens on real hardware too or not. Overall this seems a great risk for zero gain. This approach is sure safer than previous code given we can't pretend all guest fs code out there to check for errors and reply the DMA if it was completed partially, given a timeout would never materialize on a real harddisk unless there are defective blocks (and defective blocks are practically only an issue for reads never for writes in any recent hardware as writing to blocks is the way to fix them) or the harddisk breaks as a whole. Signed-off-by: Andrea Arcangeli --- Index: hw/ide.c =================================================================== --- hw/ide.c (revision 6626) +++ hw/ide.c (working copy) @@ -2983,8 +2983,27 @@ printf("%s: 0x%08x\n", __func__, val); #endif if (!(val & BM_CMD_START)) { - /* XXX: do it better */ - ide_dma_cancel(bm); + /* + * We can't cancel Scatter Gather DMA in the middle of the + * operation or a partial (not full) DMA transfer would reach + * the storage so we wait for completion instead (we beahve + * like if the DMA was complated by the time the guest trying + * to cancel dma with bmdma_cmd_writeb with BM_CMD_START not + * set). + * + * In the future we'll be able to safely cancel the I/O if the + * whole DMA operation will be submitted to disk with a single + * aio operation with preadv/pwritev. + */ + if (bm->aiocb) { + qemu_aio_flush(); +#ifdef DEBUG_IDE + if (bm->aiocb) + printf("aiocb still pending"); + if (bm->status & BM_STATUS_DMAING) + printf("BM_STATUS_DMAING still pending"); +#endif + } bm->cmd = val & 0x09; } else { if (!(bm->status & BM_STATUS_DMAING)) {