From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ld0AW-0006Kf-IL for qemu-devel@nongnu.org; Fri, 27 Feb 2009 05:42:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ld0AS-0006Ij-Of for qemu-devel@nongnu.org; Fri, 27 Feb 2009 05:42:11 -0500 Received: from [199.232.76.173] (port=46952 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ld0AS-0006Ig-A7 for qemu-devel@nongnu.org; Fri, 27 Feb 2009 05:42:08 -0500 Received: from mx1.redhat.com ([66.187.233.31]:42242) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ld0AR-0007yH-So for qemu-devel@nongnu.org; Fri, 27 Feb 2009 05:42:08 -0500 Date: Fri, 27 Feb 2009 10:42:04 +0000 From: "Daniel P. Berrange" Subject: Re: [Qemu-devel] PATCH: 8/9: Support ACLs for controlling VNC access Message-ID: <20090227104204.GC23877@redhat.com> References: <20090226113933.GA29854@redhat.com> <20090226115730.GN22494@redhat.com> <49A712B1.20704@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49A712B1.20704@us.ibm.com> Reply-To: "Daniel P. Berrange" , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Thu, Feb 26, 2009 at 04:07:45PM -0600, Anthony Liguori wrote: > > > > > > Makefile | 6 +- > > b/acl.c | 168 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > b/acl.h | 74 ++++++++++++++++++++++++ > > monitor.c | 95 +++++++++++++++++++++++++++++++ > > vnc-auth-sasl.c | 16 ++++- > > vnc-auth-sasl.h | 7 ++ > > vnc-tls.c | 19 ++++++ > > vnc-tls.h | 3 + > > vnc.c | 14 ++++ > > vnc.h | 3 + > > 10 files changed, 398 insertions(+), 7 deletions(-) > > > > Signed-off-by: Daniel P. Berrange > > > > This breaks the win32 build. Attached are the make and config logs. > I'm using the F10 mingw packages fwiw. Ahh, I see one of the Windows system headers define a type called 'ACL' already, so I'll have to adjust that. > CC vnc.o > In file included from /home/anthony/git/qemu/vnc-tls.h:34, > from /home/anthony/git/qemu/vnc.h:79, > from /home/anthony/git/qemu/vnc.c:27: > /home/anthony/git/qemu/acl.h:31: error: conflicting types for 'ACL' > /usr/i686-pc-mingw32/sys-root/mingw/include/winnt.h:1834: error: previous declaration of 'ACL' was here Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|