* [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register
@ 2009-02-27 22:12 Riku Voipio
2009-02-27 22:45 ` Laurent Desnogues
2009-03-07 22:10 ` Aurelien Jarno
0 siblings, 2 replies; 3+ messages in thread
From: Riku Voipio @ 2009-02-27 22:12 UTC (permalink / raw)
To: qemu-devel
From: Juha Riihimäki <juha.riihimaki@nokia.com>
According to ARM Cortex A8 Technical Reference Manual, the reset value for CP15 c1 auxiliary control
register is 2, not zero (page 3.12).
Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
---
target-arm/helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index 3250fb8..883f8ee 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -1694,7 +1694,7 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t insn)
case ARM_CPUID_ARM11MPCORE:
return 1;
case ARM_CPUID_CORTEXA8:
- return 0;
+ return 2;
default:
goto bad_reg;
}
--
1.6.1.3
--
"rm -rf" only sounds scary if you don't have backups
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register
2009-02-27 22:12 [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register Riku Voipio
@ 2009-02-27 22:45 ` Laurent Desnogues
2009-03-07 22:10 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Desnogues @ 2009-02-27 22:45 UTC (permalink / raw)
To: qemu-devel
On Fri, Feb 27, 2009 at 11:12 PM, Riku Voipio <riku.voipio@iki.fi> wrote:
> From: Juha Riihimäki <juha.riihimaki@nokia.com>
>
> According to ARM Cortex A8 Technical Reference Manual, the reset value for CP15 c1 auxiliary control
> register is 2, not zero (page 3.12).
Out of curiosity does that change anything for your tests?
Laurent
Acked-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
> ---
> target-arm/helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 3250fb8..883f8ee 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -1694,7 +1694,7 @@ uint32_t HELPER(get_cp15)(CPUState *env, uint32_t insn)
> case ARM_CPUID_ARM11MPCORE:
> return 1;
> case ARM_CPUID_CORTEXA8:
> - return 0;
> + return 2;
> default:
> goto bad_reg;
> }
> --
> 1.6.1.3
>
>
> --
> "rm -rf" only sounds scary if you don't have backups
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register
2009-02-27 22:12 [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register Riku Voipio
2009-02-27 22:45 ` Laurent Desnogues
@ 2009-03-07 22:10 ` Aurelien Jarno
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2009-03-07 22:10 UTC (permalink / raw)
To: Riku Voipio; +Cc: qemu-devel
On Sat, Feb 28, 2009 at 12:12:33AM +0200, Riku Voipio wrote:
> From: Juha Riihimäki <juha.riihimaki@nokia.com>
>
> According to ARM Cortex A8 Technical Reference Manual, the reset value for CP15 c1 auxiliary control
> register is 2, not zero (page 3.12).
>
> Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-03-07 22:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-27 22:12 [Qemu-devel] [PATCH 1/3] Fix correct reset value for ARM CP15 c1 auxiliary control register Riku Voipio
2009-02-27 22:45 ` Laurent Desnogues
2009-03-07 22:10 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).