From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LdWca-0002rV-B0 for qemu-devel@nongnu.org; Sat, 28 Feb 2009 16:21:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LdWcY-0002rF-Om for qemu-devel@nongnu.org; Sat, 28 Feb 2009 16:21:19 -0500 Received: from [199.232.76.173] (port=55271 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdWcY-0002rC-Il for qemu-devel@nongnu.org; Sat, 28 Feb 2009 16:21:18 -0500 Received: from mail2.shareable.org ([80.68.89.115]:54102) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LdWcY-0001pg-88 for qemu-devel@nongnu.org; Sat, 28 Feb 2009 16:21:18 -0500 Date: Sat, 28 Feb 2009 21:21:16 +0000 From: Jamie Lokier Subject: Re: [Qemu-devel] Re: [PATCH] Fix freezing bug in curses console Message-ID: <20090228212116.GL20640@shareable.org> References: <49A843CA.2050500@us.ibm.com> <49A85541.7040805@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49A85541.7040805@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Matthew Bloch , kvm@vger.kernel.org Anthony Liguori wrote: > >>It's racy with select(). A better fix would be to create a pipe and write > >>to that pipe in the SIGWINCH handler. You should then register an io > >> > > > >Maybe a bottom half would work? The scheduling of a bh shouldn't > >constitute "real work". > > I think it still suffers from the same race condition so today it > wouldn't work. You could fix the bottom half scheduling though so that > you could safely schedule a bottom half from a signal handler (using > roughly the same trick). Fwiw, it's perfectly sensible to have a single pipe which is shared by all signal handlers, just used to say "check for work flags set". -- Jamie