From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LeDUU-0006qm-Iz for qemu-devel@nongnu.org; Mon, 02 Mar 2009 14:07:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LeDUS-0006p1-OB for qemu-devel@nongnu.org; Mon, 02 Mar 2009 14:07:50 -0500 Received: from [199.232.76.173] (port=36395 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LeDUS-0006os-JW for qemu-devel@nongnu.org; Mon, 02 Mar 2009 14:07:48 -0500 Received: from mx20.gnu.org ([199.232.41.8]:31551) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LeDUS-00074f-Am for qemu-devel@nongnu.org; Mon, 02 Mar 2009 14:07:48 -0500 Received: from mail.codesourcery.com ([65.74.133.4]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LeDUQ-0007XJ-7a for qemu-devel@nongnu.org; Mon, 02 Mar 2009 14:07:46 -0500 From: Paul Brook Subject: Re: [Qemu-devel] Re: [PATCH 2/3] PPC64: Implement slbmte Date: Mon, 2 Mar 2009 19:07:42 +0000 References: <1236013674-28082-1-git-send-email-agraf@suse.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903021907.43121.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Alexander Graf > >> target_ulong helper_load_sr (target_ulong sr_num) > >> { > >> + if (env->mmu_model & POWERPC_MMU_64) > >> + return ppc_load_sr(env, sr_num); > >> return env->sr[sr_num]; > >> } > > > > It would be faster to move the MMU model checks to translation time. > > The problem is that we don't know which -cpu the user will give us > when we run qemu-system-ppc64. You're confusing translation time with compile time. Paul