From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LeZ29-0001sB-2v
	for qemu-devel@nongnu.org; Tue, 03 Mar 2009 13:08:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LeZ27-0001rG-8d
	for qemu-devel@nongnu.org; Tue, 03 Mar 2009 13:08:00 -0500
Received: from [199.232.76.173] (port=43487 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LeZ27-0001rB-3C
	for qemu-devel@nongnu.org; Tue, 03 Mar 2009 13:07:59 -0500
Received: from mail-ew0-f173.google.com ([209.85.219.173]:52930)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <edgar.iglesias@gmail.com>) id 1LeZ26-00066y-GZ
	for qemu-devel@nongnu.org; Tue, 03 Mar 2009 13:07:58 -0500
Received: by ewy21 with SMTP id 21so2091136ewy.34
	for <qemu-devel@nongnu.org>; Tue, 03 Mar 2009 10:07:57 -0800 (PST)
Date: Wed, 4 Mar 2009 02:56:23 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [4721] CRIS: Add (untested) cpu-state save/load.
Message-ID: <20090304015623.GA8482@laped>
References: <E1K5r2C-0006LN-86@cvs.savannah.gnu.org>
	<49AD6D68.8090006@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49AD6D68.8090006@mail.berlios.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: edgar.iglesias@gmail.com, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Tue, Mar 03, 2009 at 06:48:24PM +0100, Stefan Weil wrote:
> Edgar E. Iglesias schrieb:
> > Revision: 4721
> > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4721
> > Author: edgar_igl
> > Date: 2008-06-09 23:44:20 +0000 (Mon, 09 Jun 2008)
> >
> > Log Message:
> > -----------
> > CRIS: Add (untested) cpu-state save/load.
> >
> > Modified Paths:
> > --------------
> > trunk/hw/etraxfs.c
> > trunk/target-cris/machine.c
> 
> It's indeed untested and even unused. Using compiler option
> -Wmissing-noreturn I detected several endless loops.
> 
> The appended patch fixes them - please apply it to Qemu trunk.

Thanks, applied.

Cheers

> 
> Regards
> 
> Stefan Weil
> 
> 
> PS. Antony, maybe such bugs might be a good reason to use
>     the -Wmissing-noreturn option!
> 
> 
> 

> Fix several endless loops.
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> 
> Index: target-cris/machine.c
> ===================================================================
> --- target-cris/machine.c	(Revision 6676)
> +++ target-cris/machine.c	(Arbeitskopie)
> @@ -34,14 +34,14 @@
>      qemu_put_be32(f, env->cc_size);
>      qemu_put_be32(f, env->cc_x);
>  
> -    for (s = 0; s < 4; i++) {
> +    for (s = 0; s < 4; s++) {
>          for (i = 0; i < 16; i++)
>              qemu_put_be32(f, env->sregs[s][i]);
>      }
>  
>      qemu_put_be32(f, env->mmu_rand_lfsr);
>      for (mmu = 0; mmu < 2; mmu++) {
> -        for (s = 0; s < 4; i++) {
> +        for (s = 0; s < 4; s++) {
>              for (i = 0; i < 16; i++) {
>                  qemu_put_be32(f, env->tlbsets[mmu][s][i].lo);
>                  qemu_put_be32(f, env->tlbsets[mmu][s][i].hi);
> @@ -77,14 +77,14 @@
>      env->cc_size = qemu_get_be32(f);
>      env->cc_x = qemu_get_be32(f);
>  
> -    for (s = 0; s < 4; i++) {
> +    for (s = 0; s < 4; s++) {
>          for (i = 0; i < 16; i++)
>              env->sregs[s][i] = qemu_get_be32(f);
>      }
>  
>      env->mmu_rand_lfsr = qemu_get_be32(f);
>      for (mmu = 0; mmu < 2; mmu++) {
> -        for (s = 0; s < 4; i++) {
> +        for (s = 0; s < 4; s++) {
>              for (i = 0; i < 16; i++) {
>                  env->tlbsets[mmu][s][i].lo = qemu_get_be32(f);
>                  env->tlbsets[mmu][s][i].hi = qemu_get_be32(f);