From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add and use remaining #defines for PCI device IDs
Date: Sat, 7 Mar 2009 13:39:59 +0000 [thread overview]
Message-ID: <20090307133959.GA10109@miranda.arrow> (raw)
In-Reply-To: <49B189D6.20808@us.ibm.com>
On Fri, Mar 06, 2009 at 02:38:46PM -0600, Anthony Liguori wrote:
> Can you just move the ones that aren't from Linux into a separate header
> file? The C99 comment makes no sense on it's own.
Good idea. Or maybe move the Linux ones into a separate header?
Either way, it solves the "how do I make this not look ugly" problem
which caused me to resort to C99 comments in the first place...
I'll submit a patch later.
Cheers,
--
Stuart Brady
prev parent reply other threads:[~2009-03-07 13:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 17:01 [Qemu-devel] [PATCH] Add and use remaining #defines for PCI device IDs Stuart Brady
2009-03-01 20:28 ` Paul Brook
2009-03-06 20:38 ` Anthony Liguori
2009-03-07 13:39 ` Stuart Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090307133959.GA10109@miranda.arrow \
--to=sdbrady@ntlworld.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).