From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LfwlI-0002Cw-0i
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:20 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LfwlG-0002Af-3C
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:19 -0500
Received: from [199.232.76.173] (port=35920 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LfwlF-0002AT-Qn
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:17 -0500
Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:11816)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1LfwlE-0007wX-7m
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 08:40:17 -0500
Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout02-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20090307134011.BZEY4080.mtaout02-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Sat, 7 Mar 2009 13:40:11 +0000
Received: from miranda.arrow ([213.107.21.171])
	by aamtaout04-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20090307134011.ZLCE22934.aamtaout04-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Sat, 7 Mar 2009 13:40:11 +0000
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1Lfwkx-0002dl-H3
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 13:39:59 +0000
Date: Sat, 7 Mar 2009 13:39:59 +0000
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH] Add and use remaining #defines for PCI
	device IDs
Message-ID: <20090307133959.GA10109@miranda.arrow>
References: <20090301170120.GA666@miranda.arrow> <49B189D6.20808@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49B189D6.20808@us.ibm.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Fri, Mar 06, 2009 at 02:38:46PM -0600, Anthony Liguori wrote:
> Can you just move the ones that aren't from Linux into a separate header 
> file?  The C99 comment makes no sense on it's own.

Good idea.  Or maybe move the Linux ones into a separate header?

Either way, it solves the "how do I make this not look ugly" problem
which caused me to resort to C99 comments in the first place...

I'll submit a patch later.

Cheers,
-- 
Stuart Brady