From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lfz4M-0001Zd-RF
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:08:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lfz4L-0001Yq-Bh
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:08:10 -0500
Received: from [199.232.76.173] (port=47738 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lfz4L-0001Yh-5T
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:08:09 -0500
Received: from mx20.gnu.org ([199.232.41.8]:49500)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Lfz4K-0005Ee-RL
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:08:08 -0500
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Lfz4J-0004s3-LE
	for qemu-devel@nongnu.org; Sat, 07 Mar 2009 11:08:07 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "Use the host exit syscall for
	exiting (Lauro Ramos Venancio)."
Date: Sat, 7 Mar 2009 16:08:04 +0000
References: <1236428435-28631-1-git-send-email-felipe.contreras@gmail.com>
	<200903071405.37427.paul@codesourcery.com>
	<94a0d4530903070802i18ba4445p712c4d1b9f97f836@mail.gmail.com>
In-Reply-To: <94a0d4530903070802i18ba4445p712c4d1b9f97f836@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200903071608.05037.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: qemu-devel@nongnu.org

On Saturday 07 March 2009, Felipe Contreras wrote:
> On Sat, Mar 7, 2009 at 4:05 PM, Paul Brook <paul@codesourcery.com> wrote:
> > On Saturday 07 March 2009, Felipe Contreras wrote:
> >> This breaks pthread_join on arm-linux-user.
> >>..
> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/* XXX: should free thread stack and=
 CPU env */
> >> - =C2=A0 =C2=A0 =C2=A0 =C2=A0sys_exit(arg1);
> >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0_exit(arg1);
> >
> > No. You're just reverting an earlier (also incorrect) change.
>
> That commit introduced a regression arm-linux-user, I'm just reverting
> the change.
>
> What do you propose? Leaving arm-linux-user broken is not good.

It's broken both after your patch, you're just exchanging one bit of=20
brokenness for another. The solution is to fix it properly, like I already=
=20
did.

Paul