From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [6798] tcg: optimize nor(X, Y, Y), used on PPC for not(X, Y)
Date: Tue, 10 Mar 2009 01:30:49 +0000 [thread overview]
Message-ID: <200903100130.50387.paul@codesourcery.com> (raw)
In-Reply-To: <E1Lgo4B-0007Sy-47@cvs.savannah.gnu.org>
On Monday 09 March 2009, Aurelien Jarno wrote:
> + if (GET_TCGV_I32(arg1) != GET_TCGV_I32(arg2)) {
This should be TCGV_EQUAL_I32[1]. IMHO any use of GET_TCGV outside of tcg/ is
wrong[2].
> + if (GET_TCGV_I64(arg1) != GET_TCGV_I64(arg2)) {
Likewise.
Paul
[1] It doesn't exist yet, but TCGV_EQUAL does.
[2] target-arm/translate.c is the chief offender. My excuse is that I wrote
that code before tcg_temp_free existed.
prev parent reply other threads:[~2009-03-10 1:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 22:35 [Qemu-devel] [6798] tcg: optimize nor(X, Y, Y), used on PPC for not(X, Y) Aurelien Jarno
2009-03-10 1:30 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903100130.50387.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).