From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lgr0b-0006m8-Te
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 21:43:54 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lgr0a-0006lH-8S
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 21:43:53 -0400
Received: from [199.232.76.173] (port=35649 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lgr0a-0006lB-2P
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 21:43:52 -0400
Received: from mx20.gnu.org ([199.232.41.8]:11488)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1Lgr0Z-00016Q-Lz
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 21:43:51 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1Lgqo1-0001E6-Ix
	for qemu-devel@nongnu.org; Mon, 09 Mar 2009 21:30:53 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [6798] tcg: optimize nor(X, Y, Y),
	used on PPC for not(X, Y)
Date: Tue, 10 Mar 2009 01:30:49 +0000
References: <E1Lgo4B-0007Sy-47@cvs.savannah.gnu.org>
In-Reply-To: <E1Lgo4B-0007Sy-47@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200903100130.50387.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

On Monday 09 March 2009, Aurelien Jarno wrote:
> + =C2=A0 =C2=A0if (GET_TCGV_I32(arg1) !=3D GET_TCGV_I32(arg2)) {

This should be TCGV_EQUAL_I32[1]. IMHO any use of GET_TCGV outside of tcg/ =
is=20
wrong[2].

> + =C2=A0 =C2=A0if (GET_TCGV_I64(arg1) !=3D GET_TCGV_I64(arg2)) {

Likewise.

Paul

[1] It doesn't exist yet, but TCGV_EQUAL does.
[2] target-arm/translate.c is the chief offender. My excuse is that I wrote=
=20
that code before tcg_temp_free existed.