From: Amit Shah <amit.shah@redhat.com>
To: qemu-devel@nongnu.org
Cc: kvm_autotest <uril@redhat.com>
Subject: Re: [Qemu-devel] [PATCH][RFC] Handling ':' on filenames
Date: Tue, 10 Mar 2009 09:29:07 +0530 [thread overview]
Message-ID: <20090310035907.GA3639@amit-x200.pnq.redhat.com> (raw)
In-Reply-To: <1236608548-sup-9812@blackpad>
On (Mon) Mar 09 2009 [11:27:53], Eduardo Habkost wrote:
> > > +
> > > + /* Protocol name will never start with a slash.
> > > + * This allows the user to specify absolute filenames
> > > + * containing a ":" character.
> > > + */
> > > + if (*filename == '/')
> > > + return &bdrv_raw;
> >
> > 3. The patch limits protocols names to not start with '/' (full paths).
> > I think we should apply the same logic to relative paths, so
> > protocol names would not start with '.' as well (no protocol
> > starts with '.' today):
> >
> > + if ((*filename == '/') || (*filename == '.'))
> > + return &bdrv_raw;
>
> Is ':' a valid character for Windows filenames? In this case, we
> may want to check for backslashes also.
I guess so; full paths are (at least used to be) something like
"C:\some-dir\some-file"
Amit
prev parent reply other threads:[~2009-03-10 3:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 21:28 [Qemu-devel] [PATCH][RFC] Handling ':' on filenames Eduardo Habkost
2009-03-08 11:28 ` Uri Lublin
2009-03-08 11:49 ` Stuart Brady
2009-03-09 14:32 ` Eduardo Habkost
2009-03-09 21:11 ` Jamie Lokier
2009-03-09 14:21 ` Eduardo Habkost
2009-03-09 14:27 ` Eduardo Habkost
2009-03-10 3:59 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310035907.GA3639@amit-x200.pnq.redhat.com \
--to=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uril@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).