From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LhLyv-0000uL-Vk
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 06:48:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LhLyu-0000rO-7L
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 06:48:13 -0400
Received: from [199.232.76.173] (port=40746 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LhLyu-0000rB-0t
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 06:48:12 -0400
Received: from mx1.redhat.com ([66.187.233.31]:41734)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <berrange@redhat.com>) id 1LhLyt-00044u-Iu
	for qemu-devel@nongnu.org; Wed, 11 Mar 2009 06:48:11 -0400
Date: Wed, 11 Mar 2009 10:48:09 +0000
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [Qemu-devel] Use of asprintf() breaks build on systems where
	asprintf() is not available
Message-ID: <20090311104809.GA23995@redhat.com>
References: <Pine.NEB.4.64.0903102129500.11497@otaku.freeshell.org>
	<49B6E2F9.3020803@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49B6E2F9.3020803@codemonkey.ws>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

On Tue, Mar 10, 2009 at 05:00:25PM -0500, Anthony Liguori wrote:
> Palle Lyckegaard wrote:
> >Hi,
> >
> >A few source-files, e.g. vnc.c, makes use of the (non-portable?) 
> >asprintf() function, which is not available in e.g. Solaris 10 and 
> >certain builds of OpenSolaris.
> >
> >What would be the proper "qemu" way of solving this problem? Creating 
> >a library with the functions not avilable on the host system or 
> >replacing the non-portable use(s) of the function(s) with proper 
> >portable function(s)?
> 
> Can you send in a patch to add the gnulib asprintf() with an appropriate 
> configure test?

I think it is just easier to remove the use of asprinf() from vnc.c It is
only used once and not really all that hard to remove.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|