From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Riihimaki Juha <Juha.Riihimaki@nokia.com>
Subject: Re: [Qemu-devel] [PATCH] fix ARMv7 MOV R15, xxx operation
Date: Sat, 14 Mar 2009 13:22:41 +0000 [thread overview]
Message-ID: <200903141322.42256.paul@codesourcery.com> (raw)
In-Reply-To: <240EE43F-A328-4D34-A066-11ED40D0EE34@nokia.com>
On Friday 13 March 2009, Riihimaki Juha wrote:
> On Mar 13, 2009, at 20:29, ext Paul Brook wrote:
> >> Seems a little bit clumsy approach to duplicate the same piece of
> >> code
> >> in several places imho so if you have any better suggestions...
> >
> > That's the whole point of functions.
>
> Sorry, I was just hoping to avoid duplicating code in several places,
> be that 5 lines of code, a function call, a macro or whatever. But I
> guess no such luck.
We already have a function used for setting the value of a register[1]
(store_reg). You just need to use a slightly different instruction when that
write is interworked.
Paul
[1] There are a few other obsolete variants like gen_movl_reg_TN, but they
need to go away anyway.
prev parent reply other threads:[~2009-03-14 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-13 8:10 [Qemu-devel] [PATCH] fix ARMv7 MOV R15, xxx operation Riihimaki Juha
2009-03-13 11:52 ` Paul Brook
2009-03-13 14:18 ` Riihimaki Juha
2009-03-13 15:13 ` Laurent Desnogues
2009-03-13 18:26 ` Riihimaki Juha
2009-03-13 18:29 ` Paul Brook
2009-03-13 18:57 ` Riihimaki Juha
2009-03-14 13:22 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903141322.42256.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=Juha.Riihimaki@nokia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).