From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LiTpJ-0006HU-IF
	for qemu-devel@nongnu.org; Sat, 14 Mar 2009 09:22:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LiTpE-00067g-IG
	for qemu-devel@nongnu.org; Sat, 14 Mar 2009 09:22:57 -0400
Received: from [199.232.76.173] (port=57102 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LiTpE-00067N-4J
	for qemu-devel@nongnu.org; Sat, 14 Mar 2009 09:22:52 -0400
Received: from mx20.gnu.org ([199.232.41.8]:25840)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LiTpD-0001Ey-P3
	for qemu-devel@nongnu.org; Sat, 14 Mar 2009 09:22:51 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LiTpC-0003A7-FS
	for qemu-devel@nongnu.org; Sat, 14 Mar 2009 09:22:50 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] fix ARMv7 MOV R15, xxx operation
Date: Sat, 14 Mar 2009 13:22:41 +0000
References: <D54FA883-7A6D-4E3F-A991-1E3AE8837A39@nokia.com>
	<200903131829.05627.paul@codesourcery.com>
	<240EE43F-A328-4D34-A066-11ED40D0EE34@nokia.com>
In-Reply-To: <240EE43F-A328-4D34-A066-11ED40D0EE34@nokia.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903141322.42256.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Riihimaki Juha <Juha.Riihimaki@nokia.com>

On Friday 13 March 2009, Riihimaki Juha wrote:
> On Mar 13, 2009, at 20:29, ext Paul Brook wrote:
> >> Seems a little bit clumsy approach to duplicate the same piece of
> >> code
> >> in several places imho so if you have any better suggestions...
> >
> > That's the whole point of functions.
>
> Sorry, I was just hoping to avoid duplicating code in several places,
> be that 5 lines of code, a function call, a macro or whatever. But I
> guess no such luck.

We already have a function used for setting the value of a register[1] 
(store_reg). You just need to use a slightly different instruction when that 
write is interworked.

Paul

[1] There are a few other obsolete variants like gen_movl_reg_TN, but they 
need to go away anyway.