From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lirkd-0004og-Dg for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:55:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LirkY-0004kE-Pd for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:55:42 -0400 Received: from [199.232.76.173] (port=53717 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LirkY-0004k7-DN for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:55:38 -0400 Received: from verein.lst.de ([213.95.11.210]:39693) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LirkX-0002OA-Pr for qemu-devel@nongnu.org; Sun, 15 Mar 2009 10:55:38 -0400 Received: from verein.lst.de (localhost [127.0.0.1]) by verein.lst.de (8.12.3/8.12.3/Debian-7.1) with ESMTP id n2FEtaIF031815 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO) for ; Sun, 15 Mar 2009 15:55:36 +0100 Received: (from hch@localhost) by verein.lst.de (8.12.3/8.12.3/Debian-6.6) id n2FEtZCs031812 for qemu-devel@nongnu.org; Sun, 15 Mar 2009 15:55:35 +0100 Date: Sun, 15 Mar 2009 15:55:35 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PACH] qemu-io - an I/O path exerciser Message-ID: <20090315145535.GA31785@lst.de> References: <20090314193346.GA3955@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Sun, Mar 15, 2009 at 04:46:33PM +0200, Blue Swirl wrote: > On 3/14/09, Christoph Hellwig wrote: > > > > This patch adds a new qemu-io tool that links against the block layer and > > image formats and allow to exercise them without needing a guest image. > > Nice, I hope we find a lot of bugs with this. > > > +static cmdinfo_t read_cmd = { > > I'd add "const" to most cmdinfo_t structures where possible. Will do.