From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LlNRs-0005g2-Qn
	for qemu-devel@nongnu.org; Sun, 22 Mar 2009 09:10:44 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LlNRo-0005fM-8O
	for qemu-devel@nongnu.org; Sun, 22 Mar 2009 09:10:44 -0400
Received: from [199.232.76.173] (port=51512 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LlNRo-0005fJ-5c
	for qemu-devel@nongnu.org; Sun, 22 Mar 2009 09:10:40 -0400
Received: from bsdimp.com ([199.45.160.85]:56033 helo=harmony.bsdimp.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <imp@bsdimp.com>) id 1LlNRn-0001ud-Kl
	for qemu-devel@nongnu.org; Sun, 22 Mar 2009 09:10:39 -0400
Date: Sun, 22 Mar 2009 07:09:06 -0600 (MDT)
Message-Id: <20090322.070906.-371303637.imp@bsdimp.com>
Subject: Re: [Qemu-devel] [PATCH] [STABLE] Clean some PCI defines
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <49C62504.8070208@mail.berlios.de>
References: <49C62504.8070208@mail.berlios.de>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, weil@mail.berlios.de

In message: <49C62504.8070208@mail.berlios.de>
            Stefan Weil <weil@mail.berlios.de> writes:
: Hello,
: 
: this patch adds some more defines from linux/pci_regs.h to
: hw/pci.h. There is now no longer a need to define them in
: eepro100.c, so they were removed there.
: 
: Some defines from linux/pci_regs.h had similar, but not
: the same defines in hw/pci.h (PCI_REVISION_ID / PCI_REVISION,
: PCI_SUBSYSTEM_VENDOR_ID / PCI_SUBVENDOR_ID,
: PCI_SUBSYSTEM_ID / PCI_SUBDEVICE_ID).
: 
: I suggest to use the "standard" from linux/pci_regs.h and
: replace the "old" Qemu ones. To facilitate the migration,
: my patch does not remove the old defines but marks them
: as obsolete. After a migration to the "standard" defines,
: pci.h could use linux/pci_regs.h which is far more complete.
: 
: The patch is needed for an updated maintainer version of
: hw/eepro100.c which I'd like to see in Qemu stable.

Maybe the right answer here is to snag the pcidevs file from NetBSD
and use it.  After all, it doesn't gratuitously introduce GPL
contamination everywhere?

Warner