From: Christoph Hellwig <hch@infradead.org>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] [PATCH][RFC] Linux AIO support when using O_DIRECT
Date: Mon, 23 Mar 2009 13:26:04 -0400 [thread overview]
Message-ID: <20090323172604.GA29449@infradead.org> (raw)
In-Reply-To: <49C7B620.8030203@redhat.com>
On Mon, Mar 23, 2009 at 06:17:36PM +0200, Avi Kivity wrote:
> Instead of introducing yet another layer of indirection, you could add
> block-raw-linux-aio, which would be registered before block-raw-posix
> (which is realy block-raw-threadpool...), and resist a ->probe() if
> caching is enabled.
Exactly the kind of comment I was about to make, but I need to read a
little deeper to understand all the details.
But my gut feeling is that this abstraction doesn't help us very much,
especially with Avi's aiocb pools in place.
prev parent reply other threads:[~2009-03-23 17:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 15:45 [Qemu-devel] [PATCH][RFC] Linux AIO support when using O_DIRECT Anthony Liguori
2009-03-23 16:17 ` Avi Kivity
2009-03-23 17:14 ` Anthony Liguori
2009-03-23 17:29 ` Christoph Hellwig
2009-03-23 18:10 ` Anthony Liguori
2009-03-23 18:48 ` Christoph Hellwig
2009-03-23 19:35 ` Avi Kivity
2009-03-23 17:32 ` Christoph Hellwig
2009-03-23 19:58 ` Avi Kivity
2009-03-23 20:32 ` Anthony Liguori
2009-03-23 17:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090323172604.GA29449@infradead.org \
--to=hch@infradead.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).