From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LmF9p-0003C1-8O
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 18:31:41 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LmF9h-00034K-Rf
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 18:31:38 -0400
Received: from [199.232.76.173] (port=41229 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LmF9h-00033h-Ci
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 18:31:33 -0400
Received: from e4.ny.us.ibm.com ([32.97.182.144]:46869)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ryanh@us.ibm.com>) id 1LmF9f-0000qs-30
	for qemu-devel@nongnu.org; Tue, 24 Mar 2009 18:31:31 -0400
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e4.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n2OMSTYM025133
	for <qemu-devel@nongnu.org>; Tue, 24 Mar 2009 18:28:29 -0400
Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id
	n2OMVT8g193230
	for <qemu-devel@nongnu.org>; Tue, 24 Mar 2009 18:31:29 -0400
Received: from d01av04.pok.ibm.com (loopback [127.0.0.1])
	by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	n2OMVSCY024803
	for <qemu-devel@nongnu.org>; Tue, 24 Mar 2009 18:31:29 -0400
Date: Tue, 24 Mar 2009 17:31:26 -0500
From: Ryan Harper <ryanh@us.ibm.com>
Subject: Re: [Qemu-devel] [BUG] [PATCH] [STABLE] Fix monitor command
	(screendump)
Message-ID: <20090324223126.GI27104@us.ibm.com>
References: <49C953E2.8090702@mail.berlios.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49C953E2.8090702@mail.berlios.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

* Stefan Weil <weil@mail.berlios.de> [2009-03-24 17:16]:
> Hello,
> 
> starting with r6839, the monitor command 'screendump'
> raises a nullpointer memory access which crashs Qemu.
> 
> My patch fixes this for trunk and for the stable branch.
> 
> Regards
> 
> Stefan
> 
> PS. There are a lot of unapplied patches (not only from me)
> which really should be applied to trunk. Much time and efforts
> are wasted for maintaining local patch trees, some fixes
> are sent 3 times by different people. How can we improve
> this insatisfying situation?
> 
> 
> 
> 
> 

> Fix crash when calling screendump from monitor.
> 
> This was a regression introduced with r6839:
> DisplayAllocator interface (Stefano Stabellini)
> 
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Acked-by: Ryan Harper <ryanh@us.ibm.com>

> 
> Index: trunk/hw/vga.c
> ===================================================================
> --- trunk.orig/hw/vga.c	2009-03-24 19:35:00.000000000 +0100
> +++ trunk/hw/vga.c	2009-03-24 19:37:56.000000000 +0100
> @@ -2637,6 +2637,7 @@
>      dcl.dpy_resize = vga_save_dpy_resize;
>      dcl.dpy_refresh = vga_save_dpy_refresh;
>      register_displaychangelistener(ds, &dcl);
> +    ds->allocator = &default_allocator;
>      ds->surface = qemu_create_displaysurface(ds, w, h);
> 
>      s->ds = ds;


-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
ryanh@us.ibm.com