From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LmZ65-00028R-5G
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:49:09 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LmZ62-00027y-WD
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:49:08 -0400
Received: from [199.232.76.173] (port=52664 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LmZ62-00027v-Q4
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:49:06 -0400
Received: from naru.obs2.net ([84.20.150.76]:49420 helo=narury.org)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <nchip@kos.to>) id 1LmZ62-0000B1-Ec
	for qemu-devel@nongnu.org; Wed, 25 Mar 2009 15:49:06 -0400
Date: Wed, 25 Mar 2009 21:49:02 +0200
From: Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] Remove -s flag in Makefile
Message-ID: <20090325194902.GA19843@kos.to>
References: <1238006714-27209-1-git-send-email-glommer@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1238006714-27209-1-git-send-email-glommer@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: markmc@redhat.com, aliguori@us.ibm.com

On Wed, Mar 25, 2009 at 03:45:14PM -0300, Glauber Costa wrote:
> install -s is pretty and cute, but makes the binary get into the build
> directory without any debug information. This is bad, and makes glommer
> sad. Also, tools that attempt to extract that data, like fedora debuginfo
> extractor, will fail.

Fully ACK, but you'll want to fix that in Makefile.target too.

> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 82fec80..859614b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -251,7 +251,7 @@ endif
>  install: all $(if $(BUILD_DOCS),install-doc)
>  	mkdir -p "$(DESTDIR)$(bindir)"
>  ifneq ($(TOOLS),)
> -	$(INSTALL) -m 755 -s $(TOOLS) "$(DESTDIR)$(bindir)"
> +	$(INSTALL) -m 755 $(TOOLS) "$(DESTDIR)$(bindir)"
>  endif
>  ifneq ($(BLOBS),)
>  	mkdir -p "$(DESTDIR)$(datadir)"
> -- 
> 1.6.0.6
> 
> 

-- 
"rm -rf" only sounds scary if you don't have backups