qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/6] more BlockDriver C99 initializers
Date: Sat, 28 Mar 2009 19:35:12 +0100	[thread overview]
Message-ID: <20090328183512.GB25497@lst.de> (raw)
In-Reply-To: <20090314192754.GA3717@lst.de>

ping?

This is a simple preparatory patch not directly related to the rest of
the series (which is beeing respun right now)

On Sat, Mar 14, 2009 at 08:27:54PM +0100, Christoph Hellwig wrote:
> 
> 
> Looks like the two bdrv_raw instances were missed last time.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: qemu/block-raw-posix.c
> ===================================================================
> --- qemu.orig/block-raw-posix.c	2009-03-14 14:46:32.000000000 +0100
> +++ qemu/block-raw-posix.c	2009-03-14 14:49:28.000000000 +0100
> @@ -847,27 +847,24 @@ static void raw_flush(BlockDriverState *
>  }
>  
>  BlockDriver bdrv_raw = {
> -    "raw",
> -    sizeof(BDRVRawState),
> -    NULL, /* no probe for protocols */
> -    raw_open,
> -    NULL,
> -    NULL,
> -    raw_close,
> -    raw_create,
> -    raw_flush,
> +    .format_name	= "raw",
> +    .instance_size	= sizeof(BDRVRawState),
> +    .bdrv_open		= raw_open,
> +    .bdrv_close		= raw_close,
> +    .bdrv_create	= raw_create,
> +    .bdrv_flush		= raw_flush,
>  
>  #ifdef CONFIG_AIO
> -    .bdrv_aio_read = raw_aio_read,
> -    .bdrv_aio_write = raw_aio_write,
> -    .bdrv_aio_cancel = raw_aio_cancel,
> -    .aiocb_size = sizeof(RawAIOCB),
> +    .bdrv_aio_read	= raw_aio_read,
> +    .bdrv_aio_write	= raw_aio_write,
> +    .bdrv_aio_cancel	= raw_aio_cancel,
> +    .aiocb_size		= sizeof(RawAIOCB),
>  #endif
>  
> -    .bdrv_read = raw_read,
> -    .bdrv_write = raw_write,
> -    .bdrv_truncate = raw_truncate,
> -    .bdrv_getlength = raw_getlength,
> +    .bdrv_read		= raw_read,
> +    .bdrv_write		= raw_write,
> +    .bdrv_truncate	= raw_truncate,
> +    .bdrv_getlength	= raw_getlength,
>  };
>  
>  /***********************************************/
> Index: qemu/block-raw-win32.c
> ===================================================================
> --- qemu.orig/block-raw-win32.c	2009-03-14 14:47:37.000000000 +0100
> +++ qemu/block-raw-win32.c	2009-03-14 14:48:39.000000000 +0100
> @@ -351,26 +351,23 @@ static int raw_create(const char *filena
>  }
>  
>  BlockDriver bdrv_raw = {
> -    "raw",
> -    sizeof(BDRVRawState),
> -    NULL, /* no probe for protocols */
> -    raw_open,
> -    NULL,
> -    NULL,
> -    raw_close,
> -    raw_create,
> -    raw_flush,
> +    .format_name	= "raw",
> +    .instance_size	= sizeof(BDRVRawState),
> +    .bdrv_open		= raw_open,
> +    .bdrv_close		= raw_close,
> +    .bdrv_create	= raw_create,
> +    .bdrv_flush		= raw_flush,
>  
>  #ifdef WIN32_AIO
> -    .bdrv_aio_read = raw_aio_read,
> -    .bdrv_aio_write = raw_aio_write,
> -    .bdrv_aio_cancel = raw_aio_cancel,
> -    .aiocb_size = sizeof(RawAIOCB);
> +    .bdrv_aio_read	= raw_aio_read,
> +    .bdrv_aio_write	= raw_aio_write,
> +    .bdrv_aio_cancel	= raw_aio_cancel,
> +    .aiocb_size		= sizeof(RawAIOCB);
>  #endif
> -    .bdrv_read = raw_read,
> -    .bdrv_write = raw_write,
> -    .bdrv_truncate = raw_truncate,
> -    .bdrv_getlength = raw_getlength,
> +    .bdrv_read		= raw_read,
> +    .bdrv_write		= raw_write,
> +    .bdrv_truncate	= raw_truncate,
> +    .bdrv_getlength	= raw_getlength,
>  };
>  
>  /***********************************************/
> 
---end quoted text---

  reply	other threads:[~2009-03-28 18:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-14 19:27 [Qemu-devel] [PATCH 0/6] add real vectored block I/O support Christoph Hellwig
2009-03-14 19:27 ` [Qemu-devel] [PATCH 1/6] more BlockDriver C99 initializers Christoph Hellwig
2009-03-28 18:35   ` Christoph Hellwig [this message]
2009-03-14 19:28 ` [Qemu-devel] [PATCH 2/6] change vectored block I/O API to plain iovecs Christoph Hellwig
2009-03-15 12:42   ` Avi Kivity
2009-03-15 13:20     ` Anthony Liguori
2009-03-15 13:36       ` Avi Kivity
2009-03-15 14:48     ` Christoph Hellwig
2009-03-15 15:07       ` Avi Kivity
2009-03-15 16:35         ` Christoph Hellwig
2009-03-14 19:28 ` [Qemu-devel] [PATCH 3/6] virtio-blk: use generic vectored I/O APIs Christoph Hellwig
2009-03-14 19:30 ` [Qemu-devel] [PATCH 4/6] remove bdrv_aio_read/bdrv_aio_write Christoph Hellwig
2009-03-14 19:30 ` [Qemu-devel] [PATCH 5/6] push down vector linearization to posix-aio-compat.c Christoph Hellwig
2009-03-14 19:31 ` [Qemu-devel] [PATCH 6/6] experimental native preadv/pwritev support for Linux Christoph Hellwig
2009-03-15 14:36   ` Blue Swirl
2009-03-15 14:44     ` Christoph Hellwig
2009-03-15 15:03       ` Blue Swirl
2009-03-15 15:16         ` Christoph Hellwig
2009-03-16 11:38   ` Gerd Hoffmann
2009-03-16 11:53     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090328183512.GB25497@lst.de \
    --to=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).