qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: qemu-devel@nongnu.org
Cc: Christoph Hellwig <hch@infradead.org>
Subject: Re: [Qemu-devel] [PATCH 3/5] push down vector linearization to	posix-aio-compat.c
Date: Sun, 29 Mar 2009 23:21:52 +0200	[thread overview]
Message-ID: <20090329212152.GA4498@lst.de> (raw)
In-Reply-To: <49CFE1A6.90509@codemonkey.ws>

On Sun, Mar 29, 2009 at 04:01:26PM -0500, Anthony Liguori wrote:
> This bug is not limited to win32 though.  It has to do with having a 
> backend disk format that does not provide a proper aio implement (which 
> suggests your new brv_aio_{readv,writev}_em at fault).  You can 
> reproduce on a normal Linux build by converting an existing image to a 
> format like vmdk and then testing with that.  It's not 100% reliable but 
> 9 times out of 10 I don't get past the grub loader with this patch applied.

This bug?  I did test cow, vmdk and vpc and can't reproduce it.  By
inspection I can find a use after free in bdrv_aio_bh_cb, though.

Will repost the whole series, the win32 aio removal and some
recent scsi-disk commits caused a whole lot of rejects..

  reply	other threads:[~2009-03-29 21:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-29 19:53 [Qemu-devel] [PATCH 0/5] add real vectored block I/O support Christoph Hellwig
2009-03-29 19:54 ` [Qemu-devel] [PATCH 1/5] more BlockDriver C99 initializers Christoph Hellwig
2009-03-29 19:54 ` [Qemu-devel] [PATCH 2/5] remove bdrv_aio_read/bdrv_aio_write Christoph Hellwig
2009-03-29 19:54 ` [Qemu-devel] [PATCH 3/5] push down vector linearization to posix-aio-compat.c Christoph Hellwig
2009-03-29 21:01   ` Anthony Liguori
2009-03-29 21:21     ` Christoph Hellwig [this message]
2009-03-29 21:44       ` Anthony Liguori
2009-03-30  6:57         ` Christoph Hellwig
2009-03-29 19:55 ` [Qemu-devel] [PATCH 4/5] native preadv/pwritev support Christoph Hellwig
2009-03-29 19:55 ` [Qemu-devel] [PATCH 5/5] experimental native preadv/pwritev support for Linux Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090329212152.GA4498@lst.de \
    --to=hch@lst.de \
    --cc=hch@infradead.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).