From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LoPnO-0006fk-Dh for qemu-devel@nongnu.org; Mon, 30 Mar 2009 18:17:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LoPnJ-0006dn-63 for qemu-devel@nongnu.org; Mon, 30 Mar 2009 18:17:29 -0400 Received: from [199.232.76.173] (port=44455 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LoPnJ-0006dk-2o for qemu-devel@nongnu.org; Mon, 30 Mar 2009 18:17:25 -0400 Received: from bsdimp.com ([199.45.160.85]:54344 helo=harmony.bsdimp.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LoPnI-0004dK-EM for qemu-devel@nongnu.org; Mon, 30 Mar 2009 18:17:24 -0400 Date: Mon, 30 Mar 2009 16:16:04 -0600 (MDT) Message-Id: <20090330.161604.-1615352452.imp@bsdimp.com> Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style From: "M. Warner Losh" In-Reply-To: <20090330214547.GQ3795@csclub.uwaterloo.ca> References: <1238361823-24939-1-git-send-email-avi@redhat.com> <20090330214547.GQ3795@csclub.uwaterloo.ca> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, lsorense@csclub.uwaterloo.ca In message: <20090330214547.GQ3795@csclub.uwaterloo.ca> lsorense@csclub.uwaterloo.ca (Lennart Sorensen) writes: : On Mon, Mar 30, 2009 at 09:28:54PM +0300, Blue Swirl wrote: : > I'd remove this, braces are not used consistently for one statement blocks. : : Then fix that. Making the coding style worse just because some people : have failed to follow it is not the right solution. : : > No, this is the K&R style. Quoting linux/Documentation/CodingStyle: : > : > Heretic people all over the world have claimed that this inconsistency : > is ... well ... inconsistent, but all right-thinking people know that : > (a) K&R are _right_ and (b) K&R are right. Besides, functions are : > special anyway (you can't nest them in C). : : And Linus is wrong for not requiring braces at all times in the kernel. :) : I don't have much hope of convincing him of that, but he is still wrong. And this is an example of the religious nature of this argument :) Warner