From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LoPIn-0007RC-5F for qemu-devel@nongnu.org; Mon, 30 Mar 2009 17:45:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LoPIi-0007QX-Pz for qemu-devel@nongnu.org; Mon, 30 Mar 2009 17:45:52 -0400 Received: from [199.232.76.173] (port=37369 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LoPIi-0007QU-Kp for qemu-devel@nongnu.org; Mon, 30 Mar 2009 17:45:48 -0400 Received: from caffeine.csclub.uwaterloo.ca ([129.97.134.17]:44170) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LoPIi-0005sC-A8 for qemu-devel@nongnu.org; Mon, 30 Mar 2009 17:45:48 -0400 Received: from caffeine.csclub.uwaterloo.ca (localhost [127.0.0.1]) by caffeine.csclub.uwaterloo.ca (Postfix) with ESMTP id 0CBF073DD6 for ; Mon, 30 Mar 2009 17:45:48 -0400 (EDT) Date: Mon, 30 Mar 2009 17:45:47 -0400 Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style Message-ID: <20090330214547.GQ3795@csclub.uwaterloo.ca> References: <1238361823-24939-1-git-send-email-avi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Mar 30, 2009 at 09:28:54PM +0300, Blue Swirl wrote: > I'd remove this, braces are not used consistently for one statement blocks. Then fix that. Making the coding style worse just because some people have failed to follow it is not the right solution. > No, this is the K&R style. Quoting linux/Documentation/CodingStyle: > > Heretic people all over the world have claimed that this inconsistency > is ... well ... inconsistent, but all right-thinking people know that > (a) K&R are _right_ and (b) K&R are right. Besides, functions are > special anyway (you can't nest them in C). And Linus is wrong for not requiring braces at all times in the kernel. :) I don't have much hope of convincing him of that, but he is still wrong. -- Len Sorensen