From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LoWk8-0007kN-VF for qemu-devel@nongnu.org; Tue, 31 Mar 2009 01:42:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LoWk3-0007eq-Ml for qemu-devel@nongnu.org; Tue, 31 Mar 2009 01:42:36 -0400 Received: from [199.232.76.173] (port=48864 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LoWk3-0007eg-Ca for qemu-devel@nongnu.org; Tue, 31 Mar 2009 01:42:31 -0400 Received: from mx2.redhat.com ([66.187.237.31]:51495) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LoWk2-00052f-TN for qemu-devel@nongnu.org; Tue, 31 Mar 2009 01:42:31 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2V5gT3J020093 for ; Tue, 31 Mar 2009 01:42:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2V5gUKV001216 for ; Tue, 31 Mar 2009 01:42:30 -0400 Received: from dhcp-1-237.tlv.redhat.com (dhcp-1-237.tlv.redhat.com [10.35.1.237]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2V5gT8N003160 for ; Tue, 31 Mar 2009 01:42:29 -0400 Date: Tue, 31 Mar 2009 08:42:28 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style Message-ID: <20090331054228.GF7285@redhat.com> References: <1238361823-24939-1-git-send-email-avi@redhat.com> <20090330214547.GQ3795@csclub.uwaterloo.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090330214547.GQ3795@csclub.uwaterloo.ca> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, Mar 30, 2009 at 05:45:47PM -0400, Lennart Sorensen wrote: > On Mon, Mar 30, 2009 at 09:28:54PM +0300, Blue Swirl wrote: > > I'd remove this, braces are not used consistently for one statement blocks. > > Then fix that. Making the coding style worse just because some people > have failed to follow it is not the right solution. > > > No, this is the K&R style. Quoting linux/Documentation/CodingStyle: > > > > Heretic people all over the world have claimed that this inconsistency > > is ... well ... inconsistent, but all right-thinking people know that > > (a) K&R are _right_ and (b) K&R are right. Besides, functions are > > special anyway (you can't nest them in C). > > And Linus is wrong for not requiring braces at all times in the kernel. :) > I don't have much hope of convincing him of that, but he is still wrong. > Try it anyway. Do it on LKML. It will be entertaining. -- Gleb.