From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style
Date: Tue, 31 Mar 2009 13:47:34 +0000 [thread overview]
Message-ID: <200903311447.34603.paul@codesourcery.com> (raw)
In-Reply-To: <1238361823-24939-1-git-send-email-avi@redhat.com>
> +2. Line width
> +
> +Lines are 80 characters wide plus some slop. Try to fit your code into
> +eighty characters, but if it makes a snippet particularly ugly, allow
> +yourself some slack. Don't overdo it though.
I'd remove the "plus some slop". My guess is that most people using a
non-graphical editor (and probably many of those using graphical variants of
vi/emacs) still wrap at 80 characters. If you can't find a convenient place
to break the line, then maybe you're doing something else wrong (e.g. using
40-character variable names :-)
Other than that, looks ok.
Paul
next prev parent reply other threads:[~2009-03-31 13:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 21:23 [Qemu-devel] [PATCH] Document Qemu coding style Avi Kivity
2009-03-30 1:15 ` malc
2009-03-30 18:28 ` Blue Swirl
2009-03-30 19:02 ` M. Warner Losh
2009-03-30 19:55 ` Avi Kivity
2009-03-30 19:54 ` Avi Kivity
2009-03-30 21:43 ` Lennart Sorensen
2009-03-30 22:15 ` M. Warner Losh
2009-03-30 23:38 ` Lennart Sorensen
2009-03-31 0:09 ` M. Warner Losh
2009-03-31 5:59 ` Laurent Desnogues
2009-03-31 12:58 ` David Turner
2009-03-31 13:31 ` Avi Kivity
2009-03-31 21:18 ` David Turner
2009-03-31 16:18 ` Blue Swirl
2009-03-31 21:48 ` David Turner
2009-03-31 22:38 ` malc
2009-03-31 23:28 ` David Turner
2009-03-31 23:49 ` malc
2009-04-01 0:25 ` David Turner
2009-04-01 1:02 ` malc
2009-04-01 9:04 ` Daniel P. Berrange
2009-03-30 19:58 ` Avi Kivity
2009-03-30 20:10 ` Glauber Costa
2009-03-30 20:35 ` Avi Kivity
2009-03-30 20:37 ` Glauber Costa
2009-03-30 20:20 ` Andreas Färber
2009-03-30 21:45 ` Lennart Sorensen
2009-03-30 22:16 ` M. Warner Losh
2009-03-31 5:42 ` Gleb Natapov
2009-03-31 13:47 ` Paul Brook [this message]
2009-04-01 8:51 ` Richard W.M. Jones
2009-04-01 9:04 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903311447.34603.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).